test: add tests for areas that currently dont have coverage #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add more tests to improve the quality
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing tests across multiple packages to boost coverage and introduces a coverage Makefile target.
- Adds unit tests for tools, scan, mcpserver, flag, commands/auth, and internal/creds packages
- Introduces a
coveragetarget in the Makefile for HTML report generation
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/tools/tool_test.go | Tests for NewTrivyTools and Cleanup methods |
| pkg/tools/tool.go | Refactors AddTools to build a slice before calling s.AddTools |
| pkg/tools/scan/scan_test.go | Tests for NewScanTools and getFilename |
| pkg/tools/scan/report_test.go | Tests for processResultSummary |
| pkg/mcpserver/mcp_test.go | Tests for NewMcpServer |
| pkg/flag/flag_test.go | Tests for flag registration and default values |
| pkg/commands/auth_test.go | Tests for NewAuthCommand, getInput, and getRegionFromList |
| internal/creds/verify_test.go | Comprehensive tests for JWT, HMAC, token logic, URL generation |
| internal/creds/aqua_test.go | Defines skipCI helper |
| Makefile | Adds coverage target for HTML coverage report |
Comments suppressed due to low confidence (2)
internal/creds/aqua_test.go:12
- The
skipCIfunction referencesos.Getenvand*testing.Tbut the imports block is missing"os"and"testing". Add these imports to fix the compilation error.
func skipCI(t *testing.T) {
pkg/tools/tool.go:47
- There are no existing tests covering
AddTools. Consider adding unit tests to verify that bothscanToolsandversionToolsare registered with the server under various conditions.
if t.scanTools != nil {
| ) | ||
| var tools []server.ServerTool | ||
|
|
||
| if t.scanTools != nil { |
There was a problem hiding this comment.
[nitpick] Since scanTools and versionTools are always initialized in NewTrivyTools, these nil checks are redundant. You could simplify this section by always appending the tools or clarifying the intended optionality.
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add more tests to improve the quality
Closes #14