fix(gr): use cosign cert if sig is keyless, not pubkey even if available #3710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts the logic for selecting the asset used for signature verification when using cosign: it now prefers the certificate asset over the public key when a keyless signature is detected.
- If the signature file ends with "-keyless.sig", the public key asset is cleared.
- The check now returns nil only when both the public key and certificate assets are absent.
Comments suppressed due to low confidence (1)
pkg/controller/generate-registry/generate.go:315
- The removal of the loop that assigns certificateAssetName based on asset suffixes might lead to certificateAssetName not being set. Please ensure that certificateAssetName is assigned appropriately elsewhere, or consider reintroducing the assignment logic to handle cases where a certificate asset is available.
if strings.HasSuffix(signatureAssetName, "-keyless.sig") {
``` Error: pkg/controller/generate-registry/generate.go:319:134: directive `//nolint:cyclop` is unused for linter "cyclop" (nolintlint) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example in https://github.com/sigstore/cosign/releases/tag/v2.4.3
Check List
Require signed commits, so all commits must be signed