fix(cp): adds missing .exe on windows #4047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@suzuki-shunsuke Thanks for a great project! I built and tested this locally on Windows, and confirmed that the copied executables now contain the |
pkg/installpackage/check_file.go
Outdated
| for exeName := range exeNames { | ||
| if err := is.Copy(filepath.Join(is.copyDir, exeName), exePath); err != nil { | ||
| p := filepath.Join(is.copyDir, exeName) | ||
| if is.runtime.GOOS == "windows" && filepath.Ext(exeName) == "" { |
There was a problem hiding this comment.
Suggested change
| if is.runtime.GOOS == "windows" && filepath.Ext(exeName) == "" { | |
| if is.runtime.IsWindows() && filepath.Ext(exeName) == "" { |
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Require signed commits, so all commits must be signedThis PR fixes #4046. The
aqua cpcommand (without arguments) copies the executables for all packages to a specific location, however, it failed to add the.exeextension for those executables on Windows. It now correctly adds the missing.exeextension.The fix follows the convention established by the
aqua cp <package>command:aqua/pkg/controller/cp/copy.go
Lines 11 to 24 in 5492d2c