fix(segmentio/golines): switch the package type to `github_release` #38318

risu729 · 2025-07-02T03:48:58Z

Check List

Read CONTRIBUTING.md
- Read OSS Contribution Guide
All commits are signed
- This repository enables Require signed commits, so all commits must be signed
Avoid force push
Install and execute the package and confirm if the package works well
Execute cmdx s to scaffold code

Switches the package type from go_install to github_release.

They started releasing assets from v0.12.0. PR: segmentio/golines#117

cmdx t segmentio/golines fails for Windows (even without this change). I couldn't figure it out, so could you take a look?

I manually commented out the Windows test in cmdx.yaml, and it passed.
The following log is Windows-only.

$ cmdx t segmentio/golines
+ PACKAGE=${PACKAGE#https://github.com/}

pkg=$(bash scripts/get_test_pkg.sh "$PACKAGE")
if [ "$IS_RECREATE" = true ]; then
  cmdx rm
fi

# bash scripts/start.sh
# bash scripts/test.sh "$pkg"
bash scripts/start.sh aqua-registry-windows
bash scripts/test-windows.sh "$pkg"
aqua exec -- aqua-registry gr

[INFO] Checking if the container aqua-registry-windows exists
[INFO] Creating a container aqua-registry-windows
05a6f4355901de9fbdd539dedefda0c9141e40b2c8943c64cbb7a03fa87e2d48
Successfully copied 2.05kB to aqua-registry-windows:/workspace/pkg.yaml
Successfully copied 2.56kB to aqua-registry-windows:/workspace/registry.yaml
INFO[0000] download and unarchive the package            env=windows/amd64 package_name=aqua-proxy package_version=v1.2.9 program=aqua program_version=2.53.3 registry=
INFO[0001] create a symbolic link                        env=windows/amd64 package_name=aqua-proxy package_version=v1.2.9 program=aqua program_version=2.53.3 registry=
INFO[0001] create a symbolic link                        command=golines env=windows/amd64 package_name=segmentio/golines package_version=v0.12.2 program=aqua program_version=2.53.3
INFO[0001] Installing a Go tool                          env=windows/amd64 go_package_path=github.com/segmentio/golines@v0.11.0 gobin=/root/.local/share/aquaproj-aqua/pkgs/go_install/github.com/segmentio/golines/v0.11.0/bin package_name=segmentio/golines package_version=v0.11.0 program=aqua program_version=2.53.3 registry=standard
INFO[0001] Installing a Go tool                          env=windows/amd64 go_package_path=github.com/segmentio/golines@v0.12.2 gobin=/root/.local/share/aquaproj-aqua/pkgs/go_install/github.com/segmentio/golines/v0.12.2/bin package_name=segmentio/golines package_version=v0.12.2 program=aqua program_version=2.53.3 registry=standard
go: downloading github.com/segmentio/golines v0.11.0
go: downloading github.com/segmentio/golines v0.12.2
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading github.com/sirupsen/logrus v1.9.3
go: downloading golang.org/x/term v0.16.0
go: downloading gopkg.in/alecthomas/kingpin.v2 v2.2.6
go: downloading github.com/dave/dst v0.27.3
go: downloading github.com/x-cray/logrus-prefixed-formatter v0.5.2
go: downloading github.com/fatih/structtag v1.2.0
go: downloading github.com/fatih/structtag v1.2.0
go: downloading github.com/dave/dst v0.27.0
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading github.com/x-cray/logrus-prefixed-formatter v0.5.2
go: downloading gopkg.in/alecthomas/kingpin.v2 v2.2.6
go: downloading golang.org/x/crypto v0.0.0-20220517005047-85d78b3ac167
go: downloading github.com/sirupsen/logrus v1.4.2
go: downloading golang.org/x/crypto v0.18.0
go: downloading github.com/mgutz/ansi v0.0.0-20200706080929-d51e80ef957d
go: downloading golang.org/x/sys v0.16.0
go: downloading github.com/mgutz/ansi v0.0.0-20170206155736-9520e82c474b
go: downloading github.com/alecthomas/units v0.0.0-20190924025748-f65c72e2690d
go: downloading github.com/alecthomas/template v0.0.0-20190718012654-fb15b899a751
go: downloading golang.org/x/sys v0.0.0-20220318055525-2edf467146b5
go: downloading github.com/alecthomas/units v0.0.0-20231202071711-9a357b53e9c9
go: downloading github.com/alecthomas/template v0.0.0-20190718012654-fb15b899a751
go: downloading github.com/mattn/go-colorable v0.1.4
go: downloading github.com/mattn/go-colorable v0.1.13
go: downloading golang.org/x/tools v0.1.10
go: downloading github.com/mattn/go-isatty v0.0.10
go: downloading github.com/mattn/go-isatty v0.0.20
go: downloading golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1
go: downloading golang.org/x/tools v0.17.0
go: downloading golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1
go: downloading golang.org/x/mod v0.6.0-dev.0.20220106191415-9b9b3d81d5e3
go: downloading golang.org/x/mod v0.14.0
ERRO[0022] check file_src is correct                     env=windows/amd64 error="check file_src is correct: exe_path isn't found: stat /root/.local/share/aquaproj-aqua/pkgs/go_install/github.com/segmentio/golines/v0.11.0/bin/golines.exe: no such file or directory" exe_path=/root/.local/share/aquaproj-aqua/pkgs/go_install/github.com/segmentio/golines/v0.11.0/bin/golines.exe file_name=golines package_name=segmentio/golines package_version=v0.11.0 program=aqua program_version=2.53.3 registry=standard
ERRO[0022] executable files aren't found
Files in the unarchived package:
golines
   env=windows/amd64 package_name=segmentio/golines package_version=v0.11.0 program=aqua program_version=2.53.3 registry=standard
ERRO[0022] install the package                           env=windows/amd64 error="check file_src is correct" package_name=segmentio/golines package_version=v0.11.0 program=aqua program_version=2.53.3 registry=standard
ERRO[0022] check file_src is correct                     env=windows/amd64 error="check file_src is correct: exe_path isn't found: stat /root/.local/share/aquaproj-aqua/pkgs/go_install/github.com/segmentio/golines/v0.12.2/bin/golines.exe: no such file or directory" exe_path=/root/.local/share/aquaproj-aqua/pkgs/go_install/github.com/segmentio/golines/v0.12.2/bin/golines.exe file_name=golines package_name=segmentio/golines package_version=v0.12.2 program=aqua program_version=2.53.3 registry=standard
ERRO[0022] executable files aren't found
Files in the unarchived package:
golines
   env=windows/amd64 package_name=segmentio/golines package_version=v0.12.2 program=aqua program_version=2.53.3 registry=standard
ERRO[0022] install the package                           env=windows/amd64 error="check file_src is correct" package_name=segmentio/golines package_version=v0.12.2 program=aqua program_version=2.53.3 registry=standard
FATA[0022] aqua failed                                   env=windows/amd64 error="it failed to install some packages" program=aqua program_version=2.53.3
[ERROR] Build failed windows/amd64
        If you want to look into the container, please run 'cmdx con windows amd64'
exit status 1

suzuki-shunsuke · 2025-07-03T01:02:17Z

cmdx t segmentio/golines fails for Windows (even without this change)

I guess this is a known issue.
The cause is that we run windows test on Linux containers.

risu729 · 2025-07-03T01:21:16Z

I see, thank you for merging!

Added numbat in aquaproj/aqua-registry#38316. Updated the registry to use the GitHub release assets in aquaproj/aqua-registry#38317, aquaproj/aqua-registry#38318. --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [aquaproj/aqua-registry](https://github.com/aquaproj/aqua-registry) | minor | `v4.381.1` -> `v4.382.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>aquaproj/aqua-registry (aquaproj/aqua-registry)</summary> ### [`v4.382.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.382.0) [Compare Source](aquaproj/aqua-registry@v4.381.1...v4.382.0) [Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.382.0) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.382.0) | aquaproj/aqua-registry@v4.381.1...v4.382.0 #### 🎉 New Packages [#38319](aquaproj/aqua-registry#38319) [siketyan/ghr](https://github.com/siketyan/ghr): Yet another repository management with auto-attaching profiles [@risu729](https://github.com/risu729) [#38316](aquaproj/aqua-registry#38316) [sharkdp/numbat](https://github.com/sharkdp/numbat): A statically typed programming language for scientific computations with first class support for physical dimensions and units [@risu729](https://github.com/risu729) [#38315](aquaproj/aqua-registry#38315) [zizmorcore/zizmor](https://github.com/zizmorcore/zizmor) Static analysis for GitHub Actions [@risu729](https://github.com/risu729) #### Improvement [#38318](aquaproj/aqua-registry#38318) segmentio/golines: Switch the package type to github\_release [@risu729](https://github.com/risu729) [#38317](aquaproj/aqua-registry#38317) cloudflare/gokey: Switch the package type to github\_release [@risu729](https://github.com/risu729) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

risu729 and others added 4 commits July 2, 2025 13:16

feat(segmentio/golines): scaffold segmentio/golines

7d1b85c

fix: support old version and windows using go_install

addabe2

fix: set files and use goos for windows override

b35359b

[autofix.ci] apply automated fixes

0589ea3

szksh-lab-project-manager bot added this to main Jul 2, 2025

suzuki-shunsuke added this to the v4.382.0 milestone Jul 3, 2025

suzuki-shunsuke merged commit 64318d1 into aquaproj:main Jul 3, 2025
17 checks passed

github-project-automation bot moved this to Done in main Jul 3, 2025

risu729 deleted the feat/segmentio/golines branch July 3, 2025 01:20

risu729 mentioned this pull request Jul 6, 2025

fix(registry): use aqua for numbat, gokey, golines jdx/mise#5518

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(segmentio/golines): switch the package type to `github_release` #38318

fix(segmentio/golines): switch the package type to `github_release` #38318

Uh oh!

risu729 commented Jul 2, 2025 •

edited

Loading

Uh oh!

suzuki-shunsuke commented Jul 3, 2025

Uh oh!

Uh oh!

risu729 commented Jul 3, 2025

Uh oh!

Uh oh!

Uh oh!

fix(segmentio/golines): switch the package type to github_release #38318

fix(segmentio/golines): switch the package type to github_release #38318

Uh oh!

Conversation

risu729 commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Check List

Uh oh!

suzuki-shunsuke commented Jul 3, 2025

Uh oh!

Uh oh!

risu729 commented Jul 3, 2025

Uh oh!

Uh oh!

fix(segmentio/golines): switch the package type to `github_release` #38318

fix(segmentio/golines): switch the package type to `github_release` #38318

risu729 commented Jul 2, 2025 •

edited

Loading