Skip to content

Conversation

risu729
Copy link
Contributor

@risu729 risu729 commented Aug 15, 2025

Check List

Fixes the failing test in #40166.

v1.12.0 doesn't have assets, so fallback to type: cargo.
v1.12.1 doesn't have zizmor-i686-pc-windows-msvc.zip, but we're not using it.

@risu729
Copy link
Contributor Author

risu729 commented Aug 15, 2025

I'm not sure why the test fails. I can install it locally.

The error says rust-lang/rust#53667 is unstable, but is stabilised in Rust 1.88.0.
However, the actions runner should be using 1.89.0.
https://github.com/actions/runner-images/blob/8384138a4a81e8ab8ae899420de491b7c86fd935/images/ubuntu/Ubuntu2404-Readme.md?plain=1#L132
Also, zizmor correctly uses edition: 2024 and 1.89.0.
https://github.com/zizmorcore/zizmor/blob/1e3e55965553b490baeb5dce03677975e19264d2/Cargo.toml#L18C17-L18C23

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Aug 15, 2025

I debugged this using action-tmate.
https://github.com/aquaproj/aqua-registry/actions/workflows/debug-with-action-tmate.yaml

inputs:

  • pr: 40183
  • runs-on: ubuntu-24.04-arm

- runs-on: ubuntu-24.04-arm

Then I found the version of rustc is 1.87.0 < 1.88.0.

runner@runnervmdbl46:~/work/aqua-registry/aqua-registry$ rustc --version
rustc 1.87.0 (17067e9ac 2025-05-09)

runner@runnervmdbl46:~/work/aqua-registry/aqua-registry$ which rustc
/home/runner/.cargo/bin/rustc

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Aug 15, 2025

Oh, interesting.
rustc is old on only ubuntu-24.04-arm.

https://github.com/szksh-lab-2/test-github-action/actions/runs/16999917632/job/48199428654?pr=329#step:2:5

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Aug 15, 2025

@suzuki-shunsuke
Copy link
Member

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Aug 15, 2025

@suzuki-shunsuke
Copy link
Member

@suzuki-shunsuke
Copy link
Member

Oh, the build still failed.

https://github.com/aquaproj/aqua-registry/actions/runs/17000519296/job/48201271171?pr=40207

Run rustup update
info: syncing channel updates for 'stable-aarch64-unknown-linux-gnu'
info: latest update on 2025-08-07, rust version 1.89.0 (29483883e 2025-08-04)
info: downloading component 'clippy'
info: downloading component 'rustfmt'
info: downloading component 'cargo'
info: downloading component 'rust-std'
info: downloading component 'rustc'
info: removing previous version of component 'clippy'
info: removing previous version of component 'rustfmt'
info: removing previous version of component 'cargo'
info: removing previous version of component 'rust-std'
info: removing previous version of component 'rustc'
info: installing component 'clippy'
info: installing component 'rustfmt'
info: installing component 'cargo'
info: installing component 'rust-std'
info: installing component 'rustc'

info: cleaning up downloads & tmp directories
  stable-aarch64-unknown-linux-gnu updated - rustc 1.89.0 (29483883e 2025-08-04) (from rustc 1.87.0 (17067e9ac 2025-05-09))
error[E0308]: mismatched types
   --> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/zizmor-1.8.0-rc2/src/main.rs:581:13
    |
580 |         span.pb_set_style(
    |              ------------ arguments to this method are incorrect
581 |             &ProgressStyle::with_template("[{elapsed_precise}] {bar:!30.cyan/blue} {msg}").unwrap(),
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `tracing_indicatif::style::ProgressStyle`, found `indicatif::ProgressStyle`
    |
note: two different versions of crate `indicatif` are being used; two types coming from two different versions of the same crate are different types even if they look the same
   --> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/indicatif-0.18.0/src/style.rs:21:1
    |
21  | pub struct ProgressStyle {
    | ^^^^^^^^^^^^^^^^^^^^^^^^ this is the expected type `tracing_indicatif::style::ProgressStyle`
    |
   ::: /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/indicatif-0.17.11/src/style.rs:21:1
    |
21  | pub struct ProgressStyle {
    | ^^^^^^^^^^^^^^^^^^^^^^^^ this is the found type `indicatif::ProgressStyle`
    |
   ::: /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/zizmor-1.8.0-rc2/src/main.rs:19:5
    |
19  | use indicatif::ProgressStyle;
    |     --------- one version of crate `indicatif` used here, as a direct dependency of the current crate
...
24  | use tracing_indicatif::{IndicatifLayer, span_ext::IndicatifSpanExt};
    |     ----------------- one version of crate `indicatif` used here, as a dependency of crate `tracing_indicatif`
    = help: you can use `cargo tree` to explore your dependency tree
note: method defined here
   --> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tracing-indicatif-0.3.13/src/span_ext.rs:39:8
    |
39  |     fn pb_set_style(&self, style: &ProgressStyle);
    |        ^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0308`.
error: could not compile `zizmor` (bin "zizmor") due to 1 previous error
error: failed to compile `zizmor v1.8.0-rc2`, intermediate artifacts can be found at `/tmp/cargo-installRvXrWJ`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.
INFO[0088] removing the install directory because the installation failed  env=linux/arm64 install_dir=/home/runner/.local/share/aquaproj-aqua/pkgs/cargo/crates.io/zizmor/1.8.0-rc2 package_name=zizmorcore/zizmor package_version=v1.8.0-rc2 program=aqua program_version=2.53.9 registry=standard
ERRO[0088] install the package                           cargo_command="cargo install --version 1.8.0-rc2 zizmor" doc="https://aquaproj.github.io/docs/reference/codes/005" env=linux/arm64 error="cargo install: install a crate: exit status 101" package_name=zizmorcore/zizmor package_version=v1.8.0-rc2 program=aqua program_version=2.53.9 registry=standard
FATA[0088] aqua failed                                   config_file_path=/home/runner/work/aqua-registry/aqua-registry/aqua/test.yaml env=linux/arm64 error="install packages: it failed to install some packages" program=aqua program_version=2.53.9
Error: Process completed with exit code 1.

@risu729
Copy link
Contributor Author

risu729 commented Aug 16, 2025

I missed that the arm image is different, thanks!

For the rustc error, I'm not sure about the exact cause, but I think it's a dependency issue.
I'm sorry for not describing it, but that's the reason why I changed the test in 546911f.

@suzuki-shunsuke
Copy link
Member

I see. Thank you.
I'm not sure why it fails to build old versions, but for now I don't care about it.

@suzuki-shunsuke suzuki-shunsuke added this to the v4.403.1 milestone Aug 16, 2025
@suzuki-shunsuke suzuki-shunsuke merged commit ffb0fe0 into aquaproj:main Aug 16, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this to Done in main Aug 16, 2025
@risu729 risu729 deleted the fix/zizmorcore/zizmor branch August 16, 2025 05:04
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Aug 25, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [aquaproj/aqua-registry](https://github.com/aquaproj/aqua-registry) | minor | `v4.403.0` -> `v4.404.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>aquaproj/aqua-registry (aquaproj/aqua-registry)</summary>

### [`v4.404.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.404.0)

[Compare Source](aquaproj/aqua-registry@v4.403.0...v4.404.0)

[Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.404.0) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.404.0) | <aquaproj/aqua-registry@v4.403.0...v4.404.0>

#### 🎉 New Packages

[#&#8203;40343](aquaproj/aqua-registry#40343) [grafana/mcp-grafana](https://github.com/grafana/mcp-grafana): MCP server for Grafana [@&#8203;istone-you](https://github.com/istone-you)

#### Fixes

[#&#8203;40458](aquaproj/aqua-registry#40458) tstack/lnav
[#&#8203;40353](aquaproj/aqua-registry#40353) crossplane/crossplane: The command `kubectl-crossplane` was renamed to `crossplane` [@&#8203;risu729](https://github.com/risu729)
[#&#8203;40311](aquaproj/aqua-registry#40311) Re-scaffold cabal-install
[#&#8203;40298](aquaproj/aqua-registry#40298) qarmin/czkawka: Support czkawka 10.0.0
[#&#8203;40183](aquaproj/aqua-registry#40183) zizmorcore/zizmor: Support v1.12.0 which don't have assets [@&#8203;risu729](https://github.com/risu729)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS44Mi4zIiwidXBkYXRlZEluVmVyIjoiNDEuODIuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants