-
-
Notifications
You must be signed in to change notification settings - Fork 215
fix(zizmorcore/zizmor): support v1.12.0 which don't have assets #40183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm not sure why the test fails. I can install it locally. The error says rust-lang/rust#53667 is unstable, but is stabilised in Rust |
I debugged this using action-tmate. inputs:
Then I found the version of runner@runnervmdbl46:~/work/aqua-registry/aqua-registry$ rustc --version
rustc 1.87.0 (17067e9ac 2025-05-09)
runner@runnervmdbl46:~/work/aqua-registry/aqua-registry$ which rustc
/home/runner/.cargo/bin/rustc |
Oh, interesting. |
Hmm? |
Okay. https://github.com/szksh-lab-2/test-github-action/actions/runs/17000143965/job/48200118247?pr=329 |
Oh, the build still failed. https://github.com/aquaproj/aqua-registry/actions/runs/17000519296/job/48201271171?pr=40207
|
I missed that the arm image is different, thanks! For the rustc error, I'm not sure about the exact cause, but I think it's a dependency issue. |
I see. Thank you. |
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [aquaproj/aqua-registry](https://github.com/aquaproj/aqua-registry) | minor | `v4.403.0` -> `v4.404.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>aquaproj/aqua-registry (aquaproj/aqua-registry)</summary> ### [`v4.404.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.404.0) [Compare Source](aquaproj/aqua-registry@v4.403.0...v4.404.0) [Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.404.0) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.404.0) | <aquaproj/aqua-registry@v4.403.0...v4.404.0> #### 🎉 New Packages [#​40343](aquaproj/aqua-registry#40343) [grafana/mcp-grafana](https://github.com/grafana/mcp-grafana): MCP server for Grafana [@​istone-you](https://github.com/istone-you) #### Fixes [#​40458](aquaproj/aqua-registry#40458) tstack/lnav [#​40353](aquaproj/aqua-registry#40353) crossplane/crossplane: The command `kubectl-crossplane` was renamed to `crossplane` [@​risu729](https://github.com/risu729) [#​40311](aquaproj/aqua-registry#40311) Re-scaffold cabal-install [#​40298](aquaproj/aqua-registry#40298) qarmin/czkawka: Support czkawka 10.0.0 [#​40183](aquaproj/aqua-registry#40183) zizmorcore/zizmor: Support v1.12.0 which don't have assets [@​risu729](https://github.com/risu729) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS44Mi4zIiwidXBkYXRlZEluVmVyIjoiNDEuODIuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Check List
Require signed commits
, so all commits must be signedcmdx s
to scaffold codeFixes the failing test in #40166.
v1.12.0 doesn't have assets, so fallback to
type: cargo
.v1.12.1 doesn't have
zizmor-i686-pc-windows-msvc.zip
, but we're not using it.