fix(github): duplicate release pr when process is stopped at wrong moment #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment In a timing issue, the release pull request may be created but the releaser-pleaser labels not added. On the next run releaser-pleaser then creates a second release pull request. We try to reduce the chance of this happening by checking the context cancellation at the top, and if its not cancelled we run both API requests without passing along any cancellations from the parent context. Closes #215
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
==========================================
- Coverage 26.64% 26.54% -0.10%
==========================================
Files 23 23
Lines 1858 1865 +7
==========================================
Hits 495 495
- Misses 1335 1342 +7
Partials 28 28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
apricote
pushed a commit
to hetznercloud/fleeting-plugin-hetzner
that referenced
this pull request
Aug 27, 2025
…etznercloud/fleeting-plugin-hetzner!272) This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [apricote/releaser-pleaser](https://gitlab.com/apricote/releaser-pleaser) | repository | minor | `v0.6.1` -> `v0.7.0` | --- ### Release Notes <details> <summary>apricote/releaser-pleaser (apricote/releaser-pleaser)</summary> ### [`v0.7.0`](https://gitlab.com/apricote/releaser-pleaser/blob/HEAD/CHANGELOG.md#v070) [Compare Source](https://gitlab.com/apricote/releaser-pleaser/compare/v0.6.1...v0.7.0) ##### Highlights ✨ ##### Update version in `package.json` Thanks to [@​Mattzi](https://github.com/Mattzi) it is now possible to use `releaser-pleaser` in Javascript/Node.js projects with a `package.json` file. You can enable this with the option `updaters: packagejson` in the GitHub Actions / GitLab CI/CD config. All updaters, including the defaults `changelog` and `generic` can now be enabled and disabled through this field. You can find a full list in the [documentation](https://apricote.github.io/releaser-pleaser/reference/updaters.html). ##### Features - add updater for package.json ([#​213](apricote/releaser-pleaser#213)) - highlight breaking changes in release notes ([#​234](apricote/releaser-pleaser#234)) ##### Bug Fixes - filter out empty updaters in input ([#​235](apricote/releaser-pleaser#235)) - **github**: duplicate release pr when process is stopped at wrong moment ([#​236](apricote/releaser-pleaser#236)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS44Mi4xMCIsInVwZGF0ZWRJblZlciI6IjQxLjgyLjEwIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a timing issue, the release pull request may be created but the releaser-pleaser labels not added. On the next run releaser-pleaser then creates a second release pull request. We try to reduce the chance of this happening by checking the context cancellation at the top, and if its not cancelled we run both API requests without passing along any cancellations from the parent context.
Closes #215