Skip to content

Conversation

apricote
Copy link
Owner

@apricote apricote commented Jun 8, 2025

Previously all commits were authored and committed by releaser-pleaser <>. This is weird when looking at the commit. We now check with the Forge API for details on the currently authenticated user, and use that name and email as the commit author. The commit committer stays the same for now.

In GitHub, the default $GITHUB_TOKEN does not allow access to the required endpoint, so for github the user github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> is hardcoded when the request fails.

@apricote apricote self-assigned this Jun 8, 2025
@apricote apricote force-pushed the commit-user branch 2 times, most recently from 0807556 to 0a17a16 Compare June 8, 2025 10:55
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2025

Codecov Report

Attention: Patch coverage is 18.60465% with 35 lines in your changes missing coverage. Please review.

Project coverage is 24.58%. Comparing base (1779356) to head (328e29a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/forge/github/github.go 0.00% 13 Missing ⚠️
internal/forge/gitlab/gitlab.go 0.00% 11 Missing ⚠️
releaserpleaser.go 0.00% 6 Missing ⚠️
internal/git/git.go 61.53% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #187   +/-   ##
=======================================
  Coverage   24.58%   24.58%           
=======================================
  Files          22       22           
  Lines        1672     1704   +32     
=======================================
+ Hits          411      419    +8     
- Misses       1242     1266   +24     
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apricote apricote force-pushed the commit-user branch 2 times, most recently from 9a8ad8f to 0b03098 Compare June 8, 2025 11:10
@apricote apricote marked this pull request as ready for review June 8, 2025 11:11
Previously all commits were authored and committed by

    releaser-pleaser <>

This looked weird when looking at the commit. We now check with the
Forge API for details on the currently authenticated user, and use that
name and email as the commit author. The commit committer stays the same
for now.

In GitHub, the default `$GITHUB_TOKEN` does not allow access to the
required endpoint, so for github the user `github-actions[bot]
<41898282+github-actions[bot]@users.noreply.github.com>` is hardcoded
when the request fails.
@apricote apricote enabled auto-merge (squash) June 9, 2025 08:06
@apricote apricote merged commit 175d6d0 into main Jun 9, 2025
3 checks passed
@apricote apricote deleted the commit-user branch June 9, 2025 08:06
apricote pushed a commit to hetznercloud/fleeting-plugin-hetzner that referenced this pull request Jun 16, 2025
…etznercloud/fleeting-plugin-hetzner!252)

This MR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [apricote/releaser-pleaser](https://gitlab.com/apricote/releaser-pleaser) | repository | minor | `v0.5.1` -> `v0.6.0` |

---

### Release Notes

<details>
<summary>apricote/releaser-pleaser (apricote/releaser-pleaser)</summary>

### [`v0.6.0`](https://gitlab.com/apricote/releaser-pleaser/blob/HEAD/CHANGELOG.md#v060)

[Compare Source](https://gitlab.com/apricote/releaser-pleaser/compare/v0.5.1...v0.6.0)

##### ✨ Highlights

##### Reduced resource usage

`releaser-pleaser` now uses less resources:

- It now skips pushing changes to the release pull request if they are only a rebase.
- The configurations for GitHub Actions and GitLab CI/CD now makes sure that only a single job is running at the same time. On GitHub unnecessary/duplicate jobs are also automatically aborted.
- It handles the stop signals from the CI environment and tries to exit quickly.

\`\`\`yaml
concurrency:
group: releaser-pleaser
cancel-in-progress: true
\`\`\`

##### Avoid losing manual edits to release pull request

Before, releaser-pleaser was prone to overwriting user changes to the release pull request if they were made after releaser-pleaser already started running. There is now an additional check right before submitting the changes to see if the description changed, and retry if it did.

##### Proper commit authorship

Before, the release commits were created by `releaser-pleaser &lt;&gt;`. This was ugly to look at. We now check for details on the API user used to talk to the forge, and use that users details instead as the commit author. The committer is still `releaser-pleaser`.

##### Features

- real user as commit author ([#&#8203;187](apricote/releaser-pleaser#187))
- avoid pushing release branch only for rebasing ([#&#8203;114](apricote/releaser-pleaser#114))
- colorize log output ([#&#8203;195](apricote/releaser-pleaser#195))
- graceful shutdown when CI job is cancelled ([#&#8203;196](apricote/releaser-pleaser#196))
- detect changed pull request description and retry process ([#&#8203;197](apricote/releaser-pleaser#197))
- run one job concurrently to reduce chance of conflicts ([#&#8203;198](apricote/releaser-pleaser#198))

##### Bug Fixes

- crash when running in repo without any tags ([#&#8203;190](apricote/releaser-pleaser#190))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC41Ny4xIiwidXBkYXRlZEluVmVyIjoiNDAuNTcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants