Skip to content

Conversation

jooola
Copy link
Contributor

@jooola jooola commented Nov 13, 2024

Seems like the commit parser cannot handle a commit body without thinking it is a trailer.

Having a commit body should be supported.

Related to #99

@jooola
Copy link
Contributor Author

jooola commented Nov 13, 2024

Tests should fail, I am just providing the test case in this PR.

@apricote
Copy link
Owner

Looking at the conventional commits spec your example commit message seems to break it.

feat: some thing (hz/fl!144)

Fixes #15             <-- Intepreted as a footer/trailer
                      
Depends on !143       <-- Must also be a footer/trailer, but does not follow the expected format

Spec: https://www.conventionalcommits.org/en/v1.0.0/#specification

One or more footers MAY be provided one blank line after the body. Each footer MUST consist of a word token, followed by either a : or # separator, followed by a string value (this is inspired by the git trailer convention).


This is still a footgun and I would like to resolve this.

@apricote
Copy link
Owner

Fixed by #105

@apricote apricote closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants