Skip to content

Conversation

jooola
Copy link
Contributor

@jooola jooola commented Nov 5, 2024

  • Remove the stage input, users can override the releaser-pleaser job if needed.
  • Run the releaser-pleaser job as soon as possible using needs: [].

- Remove the stage input, users can override the `releaser-pleaser` job if needed.
- Run the `releaser-pleaser` job as soon as possible using `needs: []`.
# Remember to update docs/reference/gitlab-ci-component.md
---

releaser-pleaser:
stage: $[[ inputs.stage ]]
stage: build
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could even remove the stage value here, as it will default to the test stage.

@apricote
Copy link
Owner

apricote commented Nov 15, 2024

As far as I understood the GitLab CI/CD component docs it is preferred to use inputs instead of overriding the jobs. Happy to make needs configurable through an input, I will open a PR for that.

https://docs.gitlab.com/ee/ci/components/#replace-hardcoded-values-with-inputs

A common keyword with problematic hard-coded values is stage. If a component job’s stage is hardcoded, all pipelines using the component must either define the exact same stage, or override the configuration.

The preferred method is to use the input keyword for dynamic component configuration. The component user can specify the exact value they need.

@apricote
Copy link
Owner

Replaced by #101

@apricote apricote closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants