Skip to content

Conversation

apricote
Copy link
Owner

@apricote apricote commented Sep 7, 2024

We should not fail the whole process if a single commit message is
unparsable.

Instead we now log the issue and ignore the commit.

Copy link
Owner Author

apricote commented Sep 7, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @apricote and the rest of your teammates on Graphite Graphite

@apricote apricote added the bug Something isn't working label Sep 7, 2024 — with Graphite App
We should not fail the whole process if a single commit message is
unparsable.

Instead we now log the issue and ignore the commit.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.35%. Comparing base (2010ac1) to head (6bae554).

Files with missing lines Patch % Lines
cmd/rp/cmd/run.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   28.21%   28.35%   +0.13%     
==========================================
  Files          21       21              
  Lines        1042     1044       +2     
==========================================
+ Hits          294      296       +2     
  Misses        730      730              
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apricote apricote marked this pull request as ready for review September 7, 2024 19:47
Copy link
Owner Author

apricote commented Sep 7, 2024

Merge activity

@apricote apricote merged commit 5ea4165 into main Sep 7, 2024
3 checks passed
@apricote apricote deleted the parser-continue branch September 7, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants