Add inc/dec #83
Merged
Add inc/dec #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lohanidamodar
previously requested changes
Jul 24, 2025
| @@ -48,8 +48,6 @@ extension HTTPHandler : ChannelInboundHandler, RemovableChannelHandler { | |||
| var headers = HTTPHeaders() | |||
|
|
|||
| headers.add(name: "Host", value: "\(client.host):\(client.port)") | |||
| headers.add(name: "Content-Type", value: "text/plain") | |||
There was a problem hiding this comment.
is this intended and no longer required?
There was a problem hiding this comment.
Intended, this broke with proxies because some don't like content-type and content-length or a body when making a GET request
ChiragAgg5k
approved these changes
Jul 25, 2025
ChiragAgg5k
approved these changes
Jul 25, 2025
loks0n
approved these changes
Jul 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
incrementDocumentAttributeanddecrementDocumentAttributesupport toDatabasesservicegifsupport toImageFormatenumContent-Type,Content-Lengthheaders and body from websocket requestsTest Plan
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
yes.