fix: Updating the check for matching app libraries path #41139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Router
participant matchAppLibrariesPath
participant matchAppPackagesPath
User->>Router: Navigates to a path
Router->>matchAppLibrariesPath: Checks if path matches app libraries route
alt Standard Builder Path
matchAppLibrariesPath-->>Router: Match found (BUILDER_PATH + APP_LIBRARIES_EDITOR_PATH)
else Custom Builder Path
matchAppLibrariesPath-->>Router: Match found (BUILDER_CUSTOM_PATH + APP_LIBRARIES_EDITOR_PATH)
else No Match
matchAppLibrariesPath-->>Router: No match
end
Router->>matchAppPackagesPath: Checks if path matches app packages route
alt Standard Builder Path
matchAppPackagesPath-->>Router: Match found (BUILDER_PATH + APP_PACKAGES_EDITOR_PATH)
else Custom Builder Path
matchAppPackagesPath-->>Router: Match found (BUILDER_CUSTOM_PATH + APP_PACKAGES_EDITOR_PATH)
else No Match
matchAppPackagesPath-->>Router: No match
end
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Assessment against linked issues
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
ashit-rath
reviewed
Jul 28, 2025
ashit-rath
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating the check for matching app libraries path to fix the redirection to JS Libraries section when page has a custom path.
Fixes #41138
Automation
/ok-to-test tags="@tag.Sanity"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/16566848024
Commit: 55233a4
Cypress dashboard.
Tags:
@tag.SanitySpec:
Mon, 28 Jul 2025 11:27:30 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit