Skip to content

feat: implement upgrade button within editor header #41124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2025
Merged

feat: implement upgrade button within editor header #41124

merged 1 commit into from
Jul 22, 2025

Conversation

jacquesikot
Copy link
Contributor

@jacquesikot jacquesikot commented Jul 22, 2025 •
edited by github-actions bot
Loading

Summary

This PR adds an upgrade button to the IDE header, allowing users to access upgrade options directly from the editor interface.

Changes Made

  • Added ShowUpgradeMenuItem import from ee/utils/licenseHelpers
  • Integrated <ShowUpgradeMenuItem /> component into the IDE header right section
  • Positioned the upgrade menu item before the help bar for better visibility

Automation

/ok-to-test tags="@tag.Sanity, @tag.IDE"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/16440833655
Commit: e5fcc5f
Cypress dashboard.
Tags: @tag.Sanity, @tag.IDE
Spec:

Tue, 22 Jul 2025 10:38:16 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features
    • Added an upgrade menu item to the IDE header for easier access to upgrade options.

@jacquesikot jacquesikot self-assigned this Jul 22, 2025
@jacquesikot jacquesikot added the ok-to-test Required label for CI label Jul 22, 2025
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 22, 2025 •
edited
Loading

Walkthrough

A new ShowUpgradeMenuItem component is imported and added to the right section of the IDE header, positioned before the existing HelpBar. No other logic, state, or control flow is affected by this change.

Changes

File(s) Change Summary
app/client/src/pages/AppIDE/layouts/components/Header/index.tsx Imported and rendered ShowUpgradeMenuItem in the IDE header before HelpBar.

Estimated code review effort

1 (~2 minutes)

Poem

In the header’s gentle light,
A new menu takes its flight—
Upgrade beckons, shining bright,
Just before Help’s guiding sight.
Code grows with every line,
In this IDE, refined by design!
✨🛠️

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 11a5a96 and e5fcc5f.

📒 Files selected for processing (1)
  • app/client/src/pages/AppIDE/layouts/components/Header/index.tsx (2 hunks)
🧠 Learnings (2)
📓 Common learnings 
Learnt from: Aishwarya-U-R
PR: appsmithorg/appsmith#29405
File: app/client/cypress/e2e/Regression/ClientSide/Binding/TableV2_Widget_API_Pagination_spec.js:37-41
Timestamp: 2024-07-26T21:12:57.228Z
Learning: The pull request titled "test: Cypress | Replace static with Dynamic waits - Part 1" is part of a phased approach where only certain test specifications are targeted for static wait removal in the initial phase. Future phases will address additional specs.

Learnt from: Aishwarya-U-R
PR: appsmithorg/appsmith#29405
File: app/client/cypress/e2e/Regression/ClientSide/Binding/TableV2_Widget_API_Pagination_spec.js:37-41
Timestamp: 2024-10-08T15:32:39.374Z
Learning: The pull request titled "test: Cypress | Replace static with Dynamic waits - Part 1" is part of a phased approach where only certain test specifications are targeted for static wait removal in the initial phase. Future phases will address additional specs.

Learnt from: sharat87
PR: appsmithorg/appsmith#30252
File: deploy/docker/fs/usr/lib/python3/dist-packages/supervisor/appsmith_supervisor_stdout.py:21-29
Timestamp: 2024-07-26T21:12:57.228Z
Learning: The user has confirmed that the suggested changes to handle potential exceptions and improve the robustness of the `main` function in `appsmith_supervisor_stdout.py` are acceptable.

Learnt from: KelvinOm
PR: appsmithorg/appsmith#29387
File: app/client/packages/design-system/widgets/src/components/TagGroup/src/Tag.tsx:9-9
Timestamp: 2024-10-08T15:32:34.114Z
Learning: The `CloseIcon` is being moved to a common directory for better reusability across components, following the suggestion to avoid importing it from the `Modal` component's directory.

Learnt from: KelvinOm
PR: appsmithorg/appsmith#29387
File: app/client/packages/design-system/widgets/src/components/TagGroup/src/Tag.tsx:9-9
Timestamp: 2024-07-26T21:12:57.228Z
Learning: The `CloseIcon` is being moved to a common directory for better reusability across components, following the suggestion to avoid importing it from the `Modal` component's directory.
app/client/src/pages/AppIDE/layouts/components/Header/index.tsx (9)

Learnt from: KelvinOm
PR: #29387
File: app/client/packages/design-system/widgets/src/components/TagGroup/src/Tag.tsx:9-9
Timestamp: 2024-10-08T15:32:34.114Z
Learning: The CloseIcon is being moved to a common directory for better reusability across components, following the suggestion to avoid importing it from the Modal component's directory.

Learnt from: KelvinOm
PR: #29387
File: app/client/packages/design-system/widgets/src/components/TagGroup/src/Tag.tsx:9-9
Timestamp: 2024-07-26T21:12:57.228Z
Learning: The CloseIcon is being moved to a common directory for better reusability across components, following the suggestion to avoid importing it from the Modal component's directory.

Learnt from: ashit-rath
PR: #37912
File: app/client/src/git/components/QuickActions/helpers.ts:22-25
Timestamp: 2024-12-03T10:13:43.282Z
Learning: In app/client/src/git/components/QuickActions/helpers.ts, the unnecessary @ts-ignore comments will be removed in future PRs.

Learnt from: ashit-rath
PR: #38098
File: app/client/src/git/components/GitQuickActions/index.test.tsx:18-19
Timestamp: 2024-12-11T11:42:51.143Z
Learning: In app/client/src/git/components/GitQuickActions, the Statusbar component is located in the parent directory, so it should be imported and mocked using "../Statusbar".

Learnt from: brayn003
PR: #38171
File: app/client/src/git/components/DefaultBranch/DefaultBranchCE.tsx:1-14
Timestamp: 2024-12-15T17:45:48.303Z
Learning: In app/client/src/git/components/DefaultBranch/DefaultBranchCE.tsx, the feature flag check is performed at a higher level, so it's acceptable to have isGitProtectedFeatureLicensed={false} in this component.

Learnt from: brayn003
PR: #38088
File: app/client/src/git/components/GitContextProvider/hooks/useGitBranches.ts:40-43
Timestamp: 2024-12-11T08:25:39.197Z
Learning: In app/client/src/git/components/GitContextProvider/hooks/useGitBranches.ts, the useMemo hook includes dependencies artifactType and baseArtifactId in its dependency array.

Learnt from: ankitakinger
PR: #37330
File: app/client/src/pages/common/SearchBar/HomepageHeaderAction.tsx:95-95
Timestamp: 2024-11-12T11:42:28.998Z
Learning: In icon provider components within the TypeScript/React codebase, old settings icons like "settings-2-line" and "settings-control" are intentionally provided alongside new icons. These references are acceptable and should not be flagged for updates.

Learnt from: brayn003
PR: #38088
File: app/client/src/git/components/GitQuickActions/BranchButton/index.tsx:72-74
Timestamp: 2024-12-11T08:33:24.352Z
Learning: In the 'BranchButton' component in 'app/client/src/git/components/GitQuickActions/BranchButton/index.tsx' (TypeScript, React), the useEffect hook that checks for label ellipsis does not need to include currentBranch in its dependency array.

Learnt from: brayn003
PR: #38088
File: app/client/src/git/components/GitQuickActions/helpers/getPullButtonStatus.ts:16-21
Timestamp: 2024-12-11T08:31:10.356Z
Learning: In the file app/client/src/git/components/GitQuickActions/helpers/getPullButtonStatus.ts, when defining the function getPullBtnStatus, it's acceptable to use default parameters in destructuring. Do not suggest removing default parameters in this context.

🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings 
Learnt from: Aishwarya-U-R
PR: appsmithorg/appsmith#29405
File: app/client/cypress/e2e/Regression/ClientSide/Binding/TableV2_Widget_API_Pagination_spec.js:37-41
Timestamp: 2024-07-26T21:12:57.228Z
Learning: The pull request titled "test: Cypress | Replace static with Dynamic waits - Part 1" is part of a phased approach where only certain test specifications are targeted for static wait removal in the initial phase. Future phases will address additional specs.

Learnt from: Aishwarya-U-R
PR: appsmithorg/appsmith#29405
File: app/client/cypress/e2e/Regression/ClientSide/Binding/TableV2_Widget_API_Pagination_spec.js:37-41
Timestamp: 2024-10-08T15:32:39.374Z
Learning: The pull request titled "test: Cypress | Replace static with Dynamic waits - Part 1" is part of a phased approach where only certain test specifications are targeted for static wait removal in the initial phase. Future phases will address additional specs.

Learnt from: sharat87
PR: appsmithorg/appsmith#30252
File: deploy/docker/fs/usr/lib/python3/dist-packages/supervisor/appsmith_supervisor_stdout.py:21-29
Timestamp: 2024-07-26T21:12:57.228Z
Learning: The user has confirmed that the suggested changes to handle potential exceptions and improve the robustness of the `main` function in `appsmith_supervisor_stdout.py` are acceptable.

Learnt from: KelvinOm
PR: appsmithorg/appsmith#29387
File: app/client/packages/design-system/widgets/src/components/TagGroup/src/Tag.tsx:9-9
Timestamp: 2024-10-08T15:32:34.114Z
Learning: The `CloseIcon` is being moved to a common directory for better reusability across components, following the suggestion to avoid importing it from the `Modal` component's directory.

Learnt from: KelvinOm
PR: appsmithorg/appsmith#29387
File: app/client/packages/design-system/widgets/src/components/TagGroup/src/Tag.tsx:9-9
Timestamp: 2024-07-26T21:12:57.228Z
Learning: The `CloseIcon` is being moved to a common directory for better reusability across components, following the suggestion to avoid importing it from the `Modal` component's directory.
app/client/src/pages/AppIDE/layouts/components/Header/index.tsx (9)

Learnt from: KelvinOm
PR: #29387
File: app/client/packages/design-system/widgets/src/components/TagGroup/src/Tag.tsx:9-9
Timestamp: 2024-10-08T15:32:34.114Z
Learning: The CloseIcon is being moved to a common directory for better reusability across components, following the suggestion to avoid importing it from the Modal component's directory.

Learnt from: KelvinOm
PR: #29387
File: app/client/packages/design-system/widgets/src/components/TagGroup/src/Tag.tsx:9-9
Timestamp: 2024-07-26T21:12:57.228Z
Learning: The CloseIcon is being moved to a common directory for better reusability across components, following the suggestion to avoid importing it from the Modal component's directory.

Learnt from: ashit-rath
PR: #37912
File: app/client/src/git/components/QuickActions/helpers.ts:22-25
Timestamp: 2024-12-03T10:13:43.282Z
Learning: In app/client/src/git/components/QuickActions/helpers.ts, the unnecessary @ts-ignore comments will be removed in future PRs.

Learnt from: ashit-rath
PR: #38098
File: app/client/src/git/components/GitQuickActions/index.test.tsx:18-19
Timestamp: 2024-12-11T11:42:51.143Z
Learning: In app/client/src/git/components/GitQuickActions, the Statusbar component is located in the parent directory, so it should be imported and mocked using "../Statusbar".

Learnt from: brayn003
PR: #38171
File: app/client/src/git/components/DefaultBranch/DefaultBranchCE.tsx:1-14
Timestamp: 2024-12-15T17:45:48.303Z
Learning: In app/client/src/git/components/DefaultBranch/DefaultBranchCE.tsx, the feature flag check is performed at a higher level, so it's acceptable to have isGitProtectedFeatureLicensed={false} in this component.

Learnt from: brayn003
PR: #38088
File: app/client/src/git/components/GitContextProvider/hooks/useGitBranches.ts:40-43
Timestamp: 2024-12-11T08:25:39.197Z
Learning: In app/client/src/git/components/GitContextProvider/hooks/useGitBranches.ts, the useMemo hook includes dependencies artifactType and baseArtifactId in its dependency array.

Learnt from: ankitakinger
PR: #37330
File: app/client/src/pages/common/SearchBar/HomepageHeaderAction.tsx:95-95
Timestamp: 2024-11-12T11:42:28.998Z
Learning: In icon provider components within the TypeScript/React codebase, old settings icons like "settings-2-line" and "settings-control" are intentionally provided alongside new icons. These references are acceptable and should not be flagged for updates.

Learnt from: brayn003
PR: #38088
File: app/client/src/git/components/GitQuickActions/BranchButton/index.tsx:72-74
Timestamp: 2024-12-11T08:33:24.352Z
Learning: In the 'BranchButton' component in 'app/client/src/git/components/GitQuickActions/BranchButton/index.tsx' (TypeScript, React), the useEffect hook that checks for label ellipsis does not need to include currentBranch in its dependency array.

Learnt from: brayn003
PR: #38088
File: app/client/src/git/components/GitQuickActions/helpers/getPullButtonStatus.ts:16-21
Timestamp: 2024-12-11T08:31:10.356Z
Learning: In the file app/client/src/git/components/GitQuickActions/helpers/getPullButtonStatus.ts, when defining the function getPullBtnStatus, it's acceptable to use default parameters in destructuring. Do not suggest removing default parameters in this context.

🔇 Additional comments (2)
app/client/src/pages/AppIDE/layouts/components/Header/index.tsx (2)

68-68: Import looks clean and follows project conventions.

The import path ee/utils/licenseHelpers follows the enterprise edition structure pattern used elsewhere in the codebase.

198-198: Component placement aligns with PR objectives.

The ShowUpgradeMenuItem is correctly positioned before the HelpBar in the right section of the header, which matches the stated goal of improving visibility for upgrade options.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Enhancement New feature or request label Jul 22, 2025
@jacquesikot jacquesikot added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Jul 22, 2025
@jacquesikot jacquesikot merged commit b4efa72 into release Jul 22, 2025
77 of 79 checks passed
@jacquesikot jacquesikot deleted the feat/implement-upgrade-button-within-editor branch July 22, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulbarwal rahulbarwal rahulbarwal approved these changes

@hetunandu hetunandu Awaiting requested review from hetunandu

@ankitakinger ankitakinger Awaiting requested review from ankitakinger

Assignees

@jacquesikot jacquesikot

Labels
Enhancement New feature or request ok-to-test Required label for CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacquesikot @rahulbarwal