feat: add premium feature tag for paid external SaaS plugins in DataSidePane #41110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughA new feature flag, Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant DataSidePane
participant FeatureFlag
participant PluginSelector
User->>DataSidePane: Open DataSidePane
DataSidePane->>FeatureFlag: Check 'release_paid_features_tagging' & 'license_external_saas_plugins_enabled'
DataSidePane->>PluginSelector: Retrieve plugins list
loop For each datasource
DataSidePane->>PluginSelector: Find plugin for datasource
DataSidePane->>FeatureFlag: Check if premium tag should be shown
alt Should show premium tag
DataSidePane->>User: Render PremiumFeatureTag
end
end
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
app/client/src/ce/entities/FeatureFlag.ts(2 hunks)app/client/src/pages/Editor/DataSidePane/DataSidePane.tsx(6 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: abhvsn
PR: appsmithorg/appsmith#39171
File: app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/FeatureFlagServiceCEImpl.java:42-44
Timestamp: 2025-02-24T05:59:14.021Z
Learning: The reactive transition for helper methods consuming @FeatureFlagged annotations will be handled in a separate PR to maintain focused changes and proper separation of concerns.
Learnt from: Aishwarya-U-R
PR: appsmithorg/appsmith#29405
File: app/client/cypress/e2e/Regression/ClientSide/Binding/TableV2_Widget_API_Pagination_spec.js:37-41
Timestamp: 2024-07-26T21:12:57.228Z
Learning: The pull request titled "test: Cypress | Replace static with Dynamic waits - Part 1" is part of a phased approach where only certain test specifications are targeted for static wait removal in the initial phase. Future phases will address additional specs.
Learnt from: Aishwarya-U-R
PR: appsmithorg/appsmith#29405
File: app/client/cypress/e2e/Regression/ClientSide/Binding/TableV2_Widget_API_Pagination_spec.js:37-41
Timestamp: 2024-10-08T15:32:39.374Z
Learning: The pull request titled "test: Cypress | Replace static with Dynamic waits - Part 1" is part of a phased approach where only certain test specifications are targeted for static wait removal in the initial phase. Future phases will address additional specs.
Learnt from: CR
PR: appsmithorg/appsmith#0
File: .cursor/rules/index.mdc:0-0
Timestamp: 2025-06-23T12:22:10.042Z
Learning: Pull request titles in the Appsmith codebase should follow the Conventional Commits specification, using the format 'type(scope): description' with valid types such as feat, fix, docs, style, refactor, perf, test, build, ci, chore, and revert.
Learnt from: sneha122
PR: appsmithorg/appsmith#29377
File: app/client/src/pages/Editor/IntegrationEditor/CreateNewDatasourceTab.tsx:316-329
Timestamp: 2024-07-26T21:12:57.228Z
Learning: The user clarified that the feature being introduced is experimental and that automated tests will be added once the decision to keep the feature is made. This context is important for future reviews as it explains the absence of tests for certain features under development.
Learnt from: brayn003
PR: appsmithorg/appsmith#38171
File: app/client/src/git/components/DefaultBranch/DefaultBranchCE.tsx:1-14
Timestamp: 2024-12-15T17:45:48.303Z
Learning: In `app/client/src/git/components/DefaultBranch/DefaultBranchCE.tsx`, the feature flag check is performed at a higher level, so it's acceptable to have `isGitProtectedFeatureLicensed={false}` in this component.
Learnt from: albinAppsmith
PR: appsmithorg/appsmith#0
File: :0-0
Timestamp: 2024-07-26T21:12:57.228Z
Learning: The tab click functionality in the `FileTabs` component should work independently of the `release_ide_tabs_revamp_enabled` feature flag to ensure stability.
app/client/src/ce/entities/FeatureFlag.ts (4)
Learnt from: brayn003
PR: appsmithorg/appsmith#38171
File: app/client/src/git/components/DefaultBranch/DefaultBranchCE.tsx:1-14
Timestamp: 2024-12-15T17:45:48.303Z
Learning: In `app/client/src/git/components/DefaultBranch/DefaultBranchCE.tsx`, the feature flag check is performed at a higher level, so it's acceptable to have `isGitProtectedFeatureLicensed={false}` in this component.
Learnt from: abhvsn
PR: appsmithorg/appsmith#39171
File: app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/FeatureFlagServiceCEImpl.java:42-44
Timestamp: 2025-02-24T05:59:14.021Z
Learning: The reactive transition for helper methods consuming @FeatureFlagged annotations will be handled in a separate PR to maintain focused changes and proper separation of concerns.
Learnt from: albinAppsmith
PR: appsmithorg/appsmith#0
File: :0-0
Timestamp: 2024-07-26T21:12:57.228Z
Learning: The tab click functionality in the `FileTabs` component should work independently of the `release_ide_tabs_revamp_enabled` feature flag to ensure stability.
Learnt from: AmanAgarwal041
PR: appsmithorg/appsmith#38110
File: app/client/src/utils/ProductRamps/RampsControlList.ts:36-36
Timestamp: 2024-12-16T17:34:50.458Z
Learning: When adding a new feature to `RAMP_NAME` in `app/client/src/utils/ProductRamps/RampsControlList.ts`, adding it to `PRODUCT_RAMPS_LIST` may not be necessary.
app/client/src/pages/Editor/DataSidePane/DataSidePane.tsx (7)
Learnt from: brayn003
PR: appsmithorg/appsmith#38171
File: app/client/src/git/components/DefaultBranch/DefaultBranchCE.tsx:1-14
Timestamp: 2024-12-15T17:45:48.303Z
Learning: In `app/client/src/git/components/DefaultBranch/DefaultBranchCE.tsx`, the feature flag check is performed at a higher level, so it's acceptable to have `isGitProtectedFeatureLicensed={false}` in this component.
Learnt from: alex-golovanov
PR: appsmithorg/appsmith#33863
File: app/client/src/pages/Editor/DataSourceEditor/DBForm.tsx:93-98
Timestamp: 2024-07-26T21:12:57.228Z
Learning: The suggestion to optimize conditional rendering in `DatasourceDBEditor` is considered out of scope for the current issue related to making text selectable.
Learnt from: alex-golovanov
PR: appsmithorg/appsmith#33863
File: app/client/src/pages/Editor/DataSourceEditor/DBForm.tsx:93-98
Timestamp: 2024-10-08T15:32:34.115Z
Learning: The suggestion to optimize conditional rendering in `DatasourceDBEditor` is considered out of scope for the current issue related to making text selectable.
Learnt from: sharat87
PR: appsmithorg/appsmith#34471
File: app/client/src/ce/api/JSActionAPI.tsx:143-161
Timestamp: 2024-10-08T15:32:39.374Z
Learning: The `updateJSCollectionActionRefactor` method in `JSActionAPI.tsx` includes a check to ensure `action.datasource` is not null before manipulating its properties.
Learnt from: sharat87
PR: appsmithorg/appsmith#34471
File: app/client/src/ce/api/JSActionAPI.tsx:143-161
Timestamp: 2024-06-26T06:22:15.976Z
Learning: The `updateJSCollectionActionRefactor` method in `JSActionAPI.tsx` includes a check to ensure `action.datasource` is not null before manipulating its properties.
Learnt from: albinAppsmith
PR: appsmithorg/appsmith#0
File: :0-0
Timestamp: 2024-07-26T21:12:57.228Z
Learning: The tab click functionality in the `FileTabs` component should work independently of the `release_ide_tabs_revamp_enabled` feature flag to ensure stability.
Learnt from: ankitakinger
PR: appsmithorg/appsmith#37330
File: app/client/src/pages/common/SearchBar/HomepageHeaderAction.tsx:95-95
Timestamp: 2024-11-12T11:42:28.998Z
Learning: In icon provider components within the TypeScript/React codebase, old settings icons like `"settings-2-line"` and `"settings-control"` are intentionally provided alongside new icons. These references are acceptable and should not be flagged for updates.
🧬 Code Graph Analysis (1)
app/client/src/pages/Editor/DataSidePane/DataSidePane.tsx (3)
app/client/src/ce/selectors/entitiesSelector.ts (1)
getPlugins(90-91)app/client/src/ce/entities/FeatureFlag.ts (1)
FEATURE_FLAG(2-68)app/client/src/entities/Datasource/index.ts (1)
Datasource(154-162)
🔇 Additional comments (4)
app/client/src/ce/entities/FeatureFlag.ts (1)
67-67: LGTM! Feature flag implementation follows established patterns.The new feature flag is properly added to both the FEATURE_FLAG object and DEFAULT_FEATURE_FLAG_VALUE with an appropriate default value of false.
Also applies to: 120-120
app/client/src/pages/Editor/DataSidePane/DataSidePane.tsx (3)
9-9: LGTM! Import additions are appropriate.The new imports for
getPlugins,PremiumFeatureTag,PluginType,selectFeatureFlagCheck, andDatasourcetype are all correctly imported and necessary for the premium tagging functionality.Also applies to: 33-36
62-62: LGTM! Feature flag setup is properly implemented.The feature flag checks are correctly implemented using the appropriate selectors and hooks.
Also applies to: 65-70, 86-88
171-173: LGTM! Conditional rendering implementation is correct.The premium tag is properly rendered as a rightControl when the conditions are met, maintaining clean UI structure.
rahulbarwal
approved these changes
Jul 15, 2025
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/16288357598. |
|
Deploy-Preview-URL: https://ce-41110.dp.appsmith.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new premium feature tag for datasources that use paid external SaaS plugins in the DataSidePane. The tag is conditionally displayed based on a new feature flag, allowing for controlled rollout and visibility of premium integrations.
Changes
release_paid_features_taggingto theFEATURE_FLAGandDEFAULT_FEATURE_FLAG_VALUEinFeatureFlag.ts.PremiumFeatureTagcomponent.EXTERNAL_SAASand if the corresponding paid integration feature is disabled.Automation
/ok-to-test tags="@tag.Sanity, @tag.Datasource"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/16281977131
Commit: f6450ef
Cypress dashboard.
Tags:
@tag.Sanity, @tag.DatasourceSpec:
Tue, 15 Jul 2025 02:37:55 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Chores