Skip to content

feat: enable fetching organizations based on cloud billing status #41016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

feat: enable fetching organizations based on cloud billing status #41016

merged 1 commit into from
Jun 23, 2025

Conversation

jacquesikot
Copy link
Contributor

@jacquesikot jacquesikot commented Jun 23, 2025 •
edited by github-actions bot
Loading

Description

Fix failing fetch organizations endpoint when cloud billing is not enabled.

Automation

/ok-to-test tags="@tag.Sanity, @tag.Settings"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/15819205361
Commit: 690015b
Cypress dashboard.
Tags: @tag.Sanity, @tag.Settings
Spec:

Mon, 23 Jun 2025 09:03:07 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Bug Fixes
    • Improved application behavior by only fetching organizations when cloud billing is enabled, preventing unnecessary data loading.

@jacquesikot jacquesikot self-assigned this Jun 23, 2025
@jacquesikot jacquesikot added the ok-to-test Required label for CI label Jun 23, 2025
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 23, 2025 •
edited
Loading

Walkthrough

A new hook, useIsCloudBillingEnabled, is introduced in the ApplicationsMainPage component. The control flow for fetching organizations is updated: fetchMyOrganizations is now dispatched only if cloud billing is enabled, based on the hook's result, rather than unconditionally on component mount.

Changes

File(s) Change Summary
app/client/src/ce/pages/Applications/index.tsx Added useIsCloudBillingEnabled hook; fetches organizations only if cloud billing is enabled.

Suggested labels

skip-changelog

Suggested reviewers

  • ankitakinger

Poem

When billing is cloudy, fetch with care,
Only when enabled, organizations are there.
A hook now decides if the call should be made,
Less noise, less fetch, in logic well-laid.
🌥️💡

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 814fb3d and 690015b.

📒 Files selected for processing (1)
  • app/client/src/ce/pages/Applications/index.tsx (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: perform-test / server-build / server-unit-tests
  • GitHub Check: perform-test / rts-build / build
  • GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
  • GitHub Check: client-prettier / prettier-check
  • GitHub Check: client-unit-tests / client-unit-tests
  • GitHub Check: client-build / client-build
🔇 Additional comments (3)
app/client/src/ce/pages/Applications/index.tsx (3)

150-150: Clean import addition

The import follows the existing pattern and is appropriately placed.

1025-1025: Proper hook usage

The hook is called correctly within the functional component and follows React conventions.

1047-1051: Well-implemented conditional logic

The useEffect correctly implements the intended fix by only fetching organizations when cloud billing is enabled. The dependency array properly includes isCloudBillingEnabled, ensuring the effect runs when the billing status changes.

This addresses the PR objective of preventing fetch failures when cloud billing is disabled.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Enhancement New feature or request label Jun 23, 2025
@jacquesikot jacquesikot removed the ok-to-test Required label for CI label Jun 23, 2025
@jacquesikot jacquesikot added the ok-to-test Required label for CI label Jun 23, 2025
@jacquesikot jacquesikot merged commit 14ab9e7 into release Jun 23, 2025
60 of 62 checks passed
@jacquesikot jacquesikot deleted the fix/fetch-organizations-only-when-cloud-billing-enabled branch June 23, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitakinger ankitakinger ankitakinger approved these changes

@trishaanand trishaanand Awaiting requested review from trishaanand

@RakshaKShetty RakshaKShetty Awaiting requested review from RakshaKShetty

Assignees

@jacquesikot jacquesikot

Labels
Enhancement New feature or request ok-to-test Required label for CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacquesikot @ankitakinger