Skip to content

fix: upgrade tinymce latest MIT licensed version #41003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2025
Merged

fix: upgrade tinymce latest MIT licensed version #41003

merged 2 commits into from
Jun 20, 2025

Conversation

riodeuno
Copy link
Contributor

@riodeuno riodeuno commented Jun 20, 2025 •
edited by github-actions bot
Loading

Description

Fixes
https://github.com/appsmithorg/appsmith/security/dependabot/348
https://github.com/appsmithorg/appsmith/security/dependabot/347
https://github.com/appsmithorg/appsmith/security/dependabot/290

Automation

/ok-to-test tags="@tag.Widget, @tag.TextEditor, @tag.Binding"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/15773718244
Commit: a11b75e
Cypress dashboard.
Tags: @tag.Widget, @tag.TextEditor, @tag.Binding
Spec:

Fri, 20 Jun 2025 09:01:44 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features
    • Enhanced the Rich Text Editor to automatically convert unsafe embedded content to safe formats.
  • Chores
    • Updated the TinyMCE editor to version 6.8.5.

@riodeuno riodeuno self-assigned this Jun 20, 2025
@riodeuno riodeuno requested a review from a team as a code owner June 20, 2025 06:54
@riodeuno riodeuno requested review from jacquesikot and removed request for a team June 20, 2025 06:54
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 20, 2025 •
edited
Loading

Walkthrough

This change updates the TinyMCE dependency from version 6.8.3 to 6.8.5 in the client application and modifies the RichTextEditor widget's initialization to enable automatic conversion of unsafe embedded content by setting convert_unsafe_embeds: true.

Changes

Files/Paths Change Summary
app/client/package.json Bumped TinyMCE version from 6.8.3 to 6.8.5.
app/client/src/widgets/RichTextEditorWidget/component/index.tsx Added convert_unsafe_embeds: true to TinyMCE editor config.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant RichTextEditorComponent
    participant TinyMCE

    User->>RichTextEditorComponent: Loads editor
    RichTextEditorComponent->>TinyMCE: Initialize with config (convert_unsafe_embeds: true)
    TinyMCE-->>RichTextEditorComponent: Editor ready with unsafe embed conversion enabled
Loading

Possibly related PRs

Suggested labels

Rich Text Editor Widget, Widgets Product, Bug, Security, ok-to-test

Suggested reviewers

  • vivek-appsmith
  • AmanAgarwal041

Poem

TinyMCE gets a shiny new coat,
Unsafe embeds now safely float.
The editor’s shield is up to date,
With version bumps to celebrate.
Widgets safer, code refined—
Progress marches, well-aligned! 🚀

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Bug Something isn't working label Jun 20, 2025
coderabbitai[bot]
coderabbitai bot reviewed Jun 20, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
app/client/src/widgets/RichTextEditorWidget/component/index.tsx (1)

433-433: Enable unsafe embed conversion in TinyMCE
Adding convert_unsafe_embeds: true leverages the new feature in 6.8.5 to sanitize embedded content. Consider adding or updating rich-text editor tests to cover embed sanitization scenarios.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1789339 and a11b75e.

⛔ Files ignored due to path filters (1)
  • app/client/yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • app/client/package.json (1 hunks)
  • app/client/src/widgets/RichTextEditorWidget/component/index.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: client-build / client-build
  • GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
  • GitHub Check: client-lint / client-lint
  • GitHub Check: client-unit-tests / client-unit-tests
  • GitHub Check: client-prettier / prettier-check
🔇 Additional comments (1)
app/client/package.json (1)

229-229: Bump TinyMCE to v6.8.5 for MIT license compliance
Upgrading addresses dependabot alerts and ensures we’re on the latest MIT-licensed TinyMCE.
Please verify that the lockfile reflects this change and that CI installs tinymce@6.8.5 successfully.

@riodeuno riodeuno added ok-to-test Required label for CI Security Issues related to information security within the product labels Jun 20, 2025
@riodeuno riodeuno merged commit 1b69f15 into release Jun 20, 2025
50 of 53 checks passed
@riodeuno riodeuno deleted the fix/upgrade-tinymce-latest-MIT-version branch June 20, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@rahulbarwal rahulbarwal rahulbarwal approved these changes

@jacquesikot jacquesikot Awaiting requested review from jacquesikot jacquesikot is a code owner automatically assigned from appsmithorg/widgets-blocks

Assignees

@riodeuno riodeuno

Labels
Bug Something isn't working ok-to-test Required label for CI Security Issues related to information security within the product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riodeuno @rahulbarwal