Skip to content

fix: Suppress webpack-dev-server ResizeObserver loop development runtime error #40968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2025
Merged

fix: Suppress webpack-dev-server ResizeObserver loop development runtime error #40968

merged 2 commits into from
Jun 18, 2025

Conversation

riodeuno
Copy link
Contributor

@riodeuno riodeuno commented Jun 18, 2025 •
edited by github-actions bot
Loading

Description

Suppresses ResizeObserver runtime error until the usage of the ResizeObserver API is investigated.

We can prioritize this lower for now because of the following reasons:

  1. The error has existed for quite some time without issues to our users.
  2. The notifications are not lost, just delayed by the browser.
  3. The error only surfaced when webpack-dev-server was upgraded.
  4. This error is shown only during development.

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/15723923513
Commit: 590db96
Cypress dashboard.
Tags: @tag.Sanity
Spec:

Wed, 18 Jun 2025 05:43:31 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

Summary by CodeRabbit

  • Bug Fixes
    • Suppressed display of specific runtime errors related to "ResizeObserver loop completed with undelivered notifications" in the development error overlay, reducing unnecessary error popups during development.

@riodeuno riodeuno self-assigned this Jun 18, 2025
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 18, 2025 •
edited
Loading

Walkthrough

A new handler function was added to the Webpack Dev Server client overlay configuration to filter out specific runtime errors. The overlay now ignores errors with the message "ResizeObserver loop completed with undelivered notifications," preventing them from displaying during development.

Changes

File(s) Change Summary
app/client/config/webpackDevServer.config.js Added a runtimeErrors handler to the overlay config to suppress specific ResizeObserver errors.

Poem

In the land of overlays, errors did abound,
But ResizeObserver’s loop no longer makes a sound.
With a clever new filter, the devs work in peace,
Unwanted notifications finally cease.
The console is calmer, the overlay is neat,
Debugging is smoother—oh, what a treat!

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f4fe954 and 590db96.

📒 Files selected for processing (1)
  • app/client/config/webpackDevServer.config.js (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/client/config/webpackDevServer.config.js
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: build
  • GitHub Check: perform-test / rts-build / build
  • GitHub Check: perform-test / server-build / server-unit-tests
  • GitHub Check: perform-test / client-build / client-build
  • GitHub Check: client-unit-tests / client-unit-tests
  • GitHub Check: client-build / client-build
  • GitHub Check: client-prettier / prettier-check
  • GitHub Check: client-lint / client-lint
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@riodeuno riodeuno requested a review from ashit-rath June 18, 2025 03:25
@github-actions github-actions bot added the Bug Something isn't working label Jun 18, 2025
coderabbitai[bot]
coderabbitai bot reviewed Jun 18, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b8af0d3 and f4fe954.

📒 Files selected for processing (1)
  • app/client/config/webpackDevServer.config.js (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: client-lint / client-lint
  • GitHub Check: client-unit-tests / client-unit-tests
  • GitHub Check: client-prettier / prettier-check
  • GitHub Check: client-build / client-build

@riodeuno riodeuno added the ok-to-test Required label for CI label Jun 18, 2025
@riodeuno riodeuno merged commit 6459e5f into release Jun 18, 2025
79 of 81 checks passed
@riodeuno riodeuno deleted the fix/suppress-webpackdevserver-error-overlay branch June 18, 2025 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@ashit-rath ashit-rath ashit-rath approved these changes

Assignees

@riodeuno riodeuno

Labels
Bug Something isn't working ok-to-test Required label for CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riodeuno @ashit-rath