fix: Upgrade packages 2 #40947

riodeuno · 2025-06-16T12:08:07Z

Description

Upgrades undici, prismjs, formidable packages

Fixes the following issues:
https://github.com/appsmithorg/appsmith/security/dependabot/390
https://github.com/appsmithorg/appsmith/security/dependabot/410
https://github.com/appsmithorg/appsmith/security/dependabot/409

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/15682766049
Commit: 824eae2
Cypress dashboard.
Tags: @tag.All
Spec:

Mon, 16 Jun 2025 14:15:01 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

Summary by CodeRabbit

Chores
- Updated internal package resolutions to ensure compatibility and stability with select dependencies. No user-facing changes.

coderabbitai · 2025-06-16T12:08:14Z

Walkthrough

The package.json file in the client application was updated to pin specific versions of the prismjs, undici, formidable, and brace-expansion packages in the resolutions section. No changes were made to exported or public entities.

Changes

File(s)	Change Summary
app/client/package.json	Added resolutions for `prismjs@1.30.0`, `undici@6.21.2`, `formidable@2.1.3`, and `brace-expansion@1.1.12`; minor formatting update with trailing comma.

Suggested labels

ok-to-test

Suggested reviewers

vivek-appsmith

Possibly related PRs

fix: Upgrade packages #40935: Updates package resolutions in app/client/package.json, including brace-expansion and path-to-regexp, closely related to managing package versions and dependency resolutions.

Poem

Four new pins in the package tree,
Prism, Undici, Formidable, and Brace-expansion spree.
Locked in place, their versions tight,
Ensuring builds run just right.
Commas neat, dependencies true,
The codebase shines, refreshed anew!
✨

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c7e70a6 and 824eae2.

⛔ Files ignored due to path filters (1)

app/client/yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (1)

app/client/package.json (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

app/client/package.json

⏰ Context from checks skipped due to timeout of 90000ms (7)

GitHub Check: perform-test / client-build / client-build
GitHub Check: perform-test / rts-build / build
GitHub Check: perform-test / server-build / server-unit-tests
GitHub Check: client-prettier / prettier-check
GitHub Check: client-lint / client-lint
GitHub Check: client-unit-tests / client-unit-tests
GitHub Check: client-build / client-build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai · 2025-06-16T12:08:15Z

Walkthrough

This change updates the resolutions field in app/client/package.json by adding explicit version resolutions for the packages prismjs, undici, and formidable. The existing resolution for path-to-regexp remains unchanged. No other adjustments are made to the package configuration.

Changes

File(s)	Summary of Changes
app/client/package.json	Added resolutions for `prismjs@1.30.0`, `undici@6.21.2`, and `formidable@2.1.3`.

Suggested labels

ok-to-test

Poem

Three new versions join the fray,
Prism, Undici, Formidable—hurray!
The package list grows neat and tight,
With resolutions set just right.
No scripts disturbed, no configs askew,
Just a tidy update shining through!
✨

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a93521b and c7e70a6.

⛔ Files ignored due to path filters (1)

app/client/yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (1)

app/client/package.json (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

GitHub Check: client-build / client-build
GitHub Check: client-prettier / prettier-check
GitHub Check: client-unit-tests / client-unit-tests
GitHub Check: client-lint / client-lint

🔇 Additional comments (1)

app/client/package.json (1)

428-431: Explicitly pin vulnerable dependencies
Resolving prismjs, undici, and formidable to fixed versions addresses the linked Dependabot alerts. Please verify these resolutions eliminate the security flags.
#!/bin/bash
# Verify that no high-severity vulnerabilities remain
yarn install --frozen-lockfile
yarn audit --level high

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Copilot

Pull Request Overview

This PR upgrades several client-side packages to address known security vulnerabilities.

Adds pinned versions for prismjs, undici, and formidable
Updates the existing path-to-regexp resolution entry to ensure valid JSON syntax

riodeuno · 2025-06-16T12:20:13Z

/build-deploy-preview skip-tests=true

github-actions · 2025-06-16T12:20:40Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/15680638128.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 40947.
recreate: .

github-actions · 2025-06-16T12:35:26Z

Deploy-Preview-URL: https://ce-40947.dp.appsmith.com

Fix prismjs, undici, formidable

c7e70a6

riodeuno requested a review from Copilot June 16, 2025 12:08

riodeuno self-assigned this Jun 16, 2025

riodeuno added Security Issues related to information security within the product skip-changelog Adding this label to a PR prevents it from being listed in the changelog labels Jun 16, 2025

github-actions bot added Bug Something isn't working and removed skip-changelog Adding this label to a PR prevents it from being listed in the changelog labels Jun 16, 2025

Copilot AI reviewed Jun 16, 2025

View reviewed changes

riodeuno added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Jun 16, 2025

github-actions bot removed the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Jun 16, 2025

riodeuno added the ok-to-test Required label for CI label Jun 16, 2025

riodeuno added 2 commits June 16, 2025 13:51

Add brace-expansion

c3bbdb8

update yarn.lock

824eae2

pratapaprasanna approved these changes Jun 17, 2025

View reviewed changes

riodeuno merged commit 0939456 into release Jun 17, 2025
83 checks passed

riodeuno deleted the fix/dependabot-upgrades-jun-25-2 branch June 17, 2025 06:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Upgrade packages 2 #40947

fix: Upgrade packages 2 #40947

Uh oh!

riodeuno commented Jun 16, 2025 •

edited by github-actions bot

Loading

Uh oh!

coderabbitai bot commented Jun 16, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

coderabbitai bot commented Jun 16, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

Copilot AI left a comment

Uh oh!

riodeuno commented Jun 16, 2025

Uh oh!

github-actions bot commented Jun 16, 2025

Uh oh!

github-actions bot commented Jun 16, 2025

Uh oh!

Uh oh!

Uh oh!

fix: Upgrade packages 2 #40947

fix: Upgrade packages 2 #40947

Uh oh!

Conversation

riodeuno commented Jun 16, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Automation

🔍 Cypress test results

Communication

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested labels

Suggested reviewers

Possibly related PRs

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

coderabbitai bot commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested labels

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

riodeuno commented Jun 16, 2025

Uh oh!

github-actions bot commented Jun 16, 2025

Uh oh!

github-actions bot commented Jun 16, 2025

Uh oh!

Uh oh!

Uh oh!

riodeuno commented Jun 16, 2025 •

edited by github-actions bot

Loading

coderabbitai bot commented Jun 16, 2025 •

edited

Loading

coderabbitai bot commented Jun 16, 2025 •

edited

Loading