Skip to content

fix: widgets getting disappeared when page name contains parentheses #40818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2025
Merged

fix: widgets getting disappeared when page name contains parentheses #40818

merged 1 commit into from
Jun 2, 2025

Conversation

subrata71
Copy link
Contributor

@subrata71 subrata71 commented Jun 1, 2025 •
edited by sondermanish
Loading

Description

EE Counterpart: https://github.com/appsmithorg/appsmith-ee/pull/7681

Steps to reproduce this issue demonstread here: https://jam.dev/c/eced3a5a-d958-4f85-bdb9-19064e08d781

Fixes #40817

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Git"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/15379020387
Commit: c96be34
Cypress dashboard.
Tags: @tag.Git
Spec:

Sun, 01 Jun 2025 21:06:25 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Refactor
    • Improved internal handling of widget file path replacements for enhanced reliability. No changes to user-facing functionality.

@subrata71 subrata71 requested a review from a team as a code owner June 1, 2025 20:17
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 1, 2025 •
edited
Loading

Walkthrough

The change updates the method for replacing widget file path prefixes in setArtifactDependentPropertiesInJson. It replaces the previous string-based substitution with a regex-based approach using Pattern.quote and Pattern.matcher().replaceFirst(), ensuring more precise and reliable path replacement. No public interfaces or exported declarations are altered.

Changes

File(s) Change Summary
app/server/appsmith-server/src/main/java/.../ApplicationGitFileUtilsCEImpl.java Refactored widget file path replacement logic in setArtifactDependentPropertiesInJson to use regex-based substitution with Pattern.quote and Pattern.matcher().replaceFirst().

Poem

In code’s deep woods, a path replaced,
Regex now stands where strings were chased.
Patterns quoted, matches found,
Widget trails more safely bound.
With careful steps, the code refines—
Precision grows between the lines!
🧩✨

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 785dfdd and c96be34.

📒 Files selected for processing (1)
  • app/server/appsmith-server/src/main/java/com/appsmith/server/applications/git/ApplicationGitFileUtilsCEImpl.java (2 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
app/server/appsmith-server/src/main/java/com/appsmith/server/applications/git/ApplicationGitFileUtilsCEImpl.java (1)
app/client/src/workers/Evaluation/replayUtils.ts (1)
  • WIDGETS (29-29)
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: perform-test / client-build / client-build
  • GitHub Check: perform-test / rts-build / build
  • GitHub Check: perform-test / server-build / server-unit-tests
  • GitHub Check: server-spotless / spotless-check
  • GitHub Check: server-unit-tests / server-unit-tests
🔇 Additional comments (3)
app/server/appsmith-server/src/main/java/com/appsmith/server/applications/git/ApplicationGitFileUtilsCEImpl.java (3)

64-64: Use of regex Pattern import
The new import java.util.regex.Pattern is required for the regex-based path replacement logic introduced below. It avoids relying on simple string operations and properly supports escaped characters.

728-735: Escape special characters in page names for path replacement
Leveraging Pattern.quote on the concatenated prefix (including PAGE_DIRECTORY, page name, and WIDGETS) ensures that any regex metacharacters—such as parentheses—are treated literally, preventing the original disappearance bug.

744-746: Apply prefix replacement correctly with replaceFirst
Switching to replacementPattern.matcher(...).replaceFirst(replacementString) ensures only the leading path segment is replaced, avoiding unintended substitutions further down the file path.
Please add a unit or integration test covering page names with special characters (e.g., "My (Test) Page") to verify this handles parentheses and other metacharacters as expected.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@subrata71 subrata71 self-assigned this Jun 1, 2025
@github-actions github-actions bot added the Bug Something isn't working label Jun 1, 2025
@subrata71 subrata71 added ok-to-test Required label for CI and removed Bug Something isn't working labels Jun 1, 2025
@github-actions github-actions bot added the Bug Something isn't working label Jun 1, 2025
@subrata71 subrata71 requested a review from sondermanish June 1, 2025 20:20
@github-actions github-actions bot added Critical This issue needs immediate attention. Drop everything else Needs Triaging Needs attention from maintainers to triage Production labels Jun 2, 2025
@sondermanish sondermanish merged commit afc9e4e into release Jun 2, 2025
55 checks passed
@sondermanish sondermanish deleted the chore/code-split-widgets-disappearing-fix branch June 2, 2025 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sondermanish sondermanish sondermanish approved these changes

Assignees

@subrata71 subrata71

Labels
Bug Something isn't working Critical This issue needs immediate attention. Drop everything else Needs Triaging Needs attention from maintainers to triage ok-to-test Required label for CI Production
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: On retrieval of Application json from Git file system, some widgets are vanishing from pages.
2 participants
@subrata71 @sondermanish