Skip to content

fix: Don't load _all_ the workspaces into memory #40810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2025
Merged

fix: Don't load _all_ the workspaces into memory #40810

merged 1 commit into from
May 30, 2025

Conversation

sharat87
Copy link
Member

@sharat87 sharat87 commented May 30, 2025 •
edited by github-actions bot
Loading

Description

We're loading all the workspaces into memory, and not doing anything with it. This is causing memory spikes with no value to show for that memory usage.

Automation

/test sanity

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/15343142358
Commit: 0528897
Cypress dashboard.
Tags: @tag.Sanity
Spec:

Fri, 30 May 2025 09:38:28 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Refactor
    • Improved the internal process for updating and installing plugins to enhance reliability and maintainability. No visible changes to end-user functionality.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 30, 2025 •
edited
Loading

Walkthrough

The updatePlugins method in PluginScheduledTaskUtilsCEImpl.java was refactored to streamline its reactive sequence. Instead of running update and insert plugin operations in parallel and collecting unused results, the steps are now executed sequentially, discarding intermediate lists and signaling completion with Mono. An unused import was also removed.

Changes

File(s) Change Summary
.../helpers/ce/PluginScheduledTaskUtilsCEImpl.java Refactored updatePlugins method to sequentially chain update and insert plugin steps, removed unused Workspace import.

Suggested labels

ok-to-test

Poem

Plugins march in single file,
No more zipped, but in style.
Lists discarded, voids remain,
Sequential steps, clear and plain.
Imports trimmed, the code is neat—
Reactive flow, a tidy feat! 🚦

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0377b37 and 0528897.

📒 Files selected for processing (1)
  • app/server/appsmith-server/src/main/java/com/appsmith/server/helpers/ce/PluginScheduledTaskUtilsCEImpl.java (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
app/server/appsmith-server/src/main/java/com/appsmith/server/helpers/ce/PluginScheduledTaskUtilsCEImpl.java (1)
app/client/src/entities/Plugin/index.ts (1)
  • Plugin (69-85)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: server-unit-tests / server-unit-tests
🔇 Additional comments (3)
app/server/appsmith-server/src/main/java/com/appsmith/server/helpers/ce/PluginScheduledTaskUtilsCEImpl.java (3)

88-93: Good memory optimization for updatePluginsStep.

The change from collecting workspace lists to using .then() effectively discards the intermediate List<Workspace> result, preventing unnecessary memory allocation while maintaining the same functional behavior.

97-102: Consistent optimization applied to insertPluginsStep.

The refactoring follows the same pattern as updatePluginsStep, properly converting the result to Mono<Void> to avoid collecting workspace lists in memory.

104-104: Sequential execution improves clarity and maintains memory efficiency.

The change from parallel .zipWith() to sequential .then() is appropriate here since there's no functional dependency requiring the workspace lists. This maintains the memory optimization while ensuring both plugin steps complete successfully.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Bug Something isn't working label May 30, 2025
@sharat87 sharat87 marked this pull request as ready for review May 30, 2025 07:04
@NilanshBansal NilanshBansal added the ok-to-test Required label for CI label May 30, 2025
@sharat87 sharat87 merged commit fccba12 into release May 30, 2025
48 checks passed
@sharat87 sharat87 deleted the fix/loading-all-workspaces branch May 30, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trishaanand trishaanand trishaanand approved these changes

@NilanshBansal NilanshBansal NilanshBansal approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working ok-to-test Required label for CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sharat87 @trishaanand @NilanshBansal