app/server/appsmith-server/src/test/java/com/appsmith/server/solutions/CreateDBTablePageSolutionTests.java (1)

704-765: Test logic is sound, but consider refactoring to reduce duplication.

The feature flag enabled test correctly mocks the flag and verifies the expected RunBehaviourEnum.AUTOMATIC behavior for specific action types. However, there's significant code duplication with the disabled test method.

Consider extracting the common setup logic into a helper method:

+private Mono<CRUDPageResponseDTO> createMySqlCRUDPageWithFeatureFlag(String pageName, String datasourceName, boolean flagEnabled) {
+    if (flagEnabled) {
+        doReturn(Mono.just(true)).when(featureFlagService).check(FeatureFlagEnum.release_reactive_actions_enabled);
+    }
+    // Common setup logic here
+    return resultMono;
+}

app/server/appsmith-server/src/main/java/com/appsmith/server/solutions/ce/CreateDBTablePageSolutionCEImpl.java (1)

456-475: Consider optimizing feature flag check for performance

The implementation correctly uses the feature flag to control run behavior, but the flag is checked for each individual action. Since all relevant actions in the same operation would use the same flag value, consider checking the flag once and reusing the result.

Here's an optimization approach:

+ // Check feature flag once before processing actions
+ Mono<Boolean> featureFlagMono = featureFlagService
+         .check(FeatureFlagEnum.release_reactive_actions_enabled)
+         .cache(); // Cache the result for reuse
+
  return cloneActionsFromTemplateApplication(
          datasourceStorage,
          tableNameInAction,
          savedPageId,
          templateActionList,
          mappedColumnsAndTableName,
          deletedWidgets,
          pluginSpecificParams,
          templateAutogeneratedKey.toString())
- .flatMap(actionDTO -> {
-     // Check the release_reactive_actions_enabled feature flag to determine run behaviour
-     return featureFlagService
-             .check(FeatureFlagEnum.release_reactive_actions_enabled)
-             .flatMap(isEnabled -> {
+ .flatMap(actionDTO -> {
+     return featureFlagMono
+             .flatMap(isEnabled -> {
                  RunBehaviourEnum runBehaviour = (isEnabled != null && isEnabled)
                          ? RunBehaviourEnum.AUTOMATIC
                          : RunBehaviourEnum.ON_PAGE_LOAD;
                  if (StringUtils.equals(actionDTO.getName(), SELECT_QUERY)
                          || StringUtils.equals(actionDTO.getName(), FIND_QUERY)
                          || StringUtils.equals(actionDTO.getName(), LIST_QUERY)) {
                      return layoutActionService.setRunBehaviour(
                              actionDTO.getId(), runBehaviour);
                  } else {
                      return Mono.just(actionDTO);
                  }
              });
- })
+ })

This reduces redundant feature flag service calls when processing multiple actions.

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro