Skip to content

fix: add missing displayName and slug to organization reducer #40779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

fix: add missing displayName and slug to organization reducer #40779

merged 1 commit into from
May 28, 2025

Conversation

jacquesikot
Copy link
Contributor

@jacquesikot jacquesikot commented May 27, 2025 •
edited by github-actions bot
Loading

Description

Fixes a bug where the organization's displayName and slug fields were not being properly stored in the Redux state when fetching the current organization configuration.

Changes

  • Added displayName and slug fields to the FETCH_CURRENT_ORGANIZATION_CONFIG_SUCCESS reducer handler
  • These fields were already defined in the OrganizationReduxState interface but were missing from the actual state update

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/15286413781
Commit: cca1886
Cypress dashboard.
Tags: @tag.Sanity
Spec:

Tue, 27 May 2025 22:31:26 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features
    • Organization details now display additional information, including display name and slug, when viewing organization configuration.

@jacquesikot jacquesikot self-assigned this May 27, 2025
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 27, 2025 •
edited
Loading

Walkthrough

The organization reducer was updated to include the displayName and slug fields in the state when handling the FETCH_CURRENT_ORGANIZATION_CONFIG_SUCCESS action. No other logic, error handling, or exported entity signatures were changed.

Changes

File(s) Change Summary
app/client/src/ce/reducers/organizationReducer.ts Updated reducer to add displayName and slug to state on organization config fetch success.

Sequence Diagram(s)

sequenceDiagram
    participant UI
    participant Reducer
    participant State

    UI->>Reducer: Dispatch FETCH_CURRENT_ORGANIZATION_CONFIG_SUCCESS (payload: config, displayName, slug, etc.)
    Reducer->>State: Update state with config, displayName, slug, and other fields
Loading

Possibly related PRs

Suggested labels

Bug, ok-to-test

Suggested reviewers

  • ankitakinger

Poem

Two fields join the state, hooray!
displayName and slug now come to play.
The reducer grows, the config flows,
With every fetch, the detail shows.
🎉

In code we trust, in state we thrive,
Organization data comes alive!

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cb8b9b5 and cca1886.

📒 Files selected for processing (1)
  • app/client/src/ce/reducers/organizationReducer.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: perform-test / client-build / client-build
  • GitHub Check: perform-test / rts-build / build
  • GitHub Check: perform-test / server-build / server-unit-tests
  • GitHub Check: client-unit-tests / client-unit-tests
  • GitHub Check: client-prettier / prettier-check
  • GitHub Check: client-lint / client-lint
  • GitHub Check: client-build / client-build
  • GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
🔇 Additional comments (1)
app/client/src/ce/reducers/organizationReducer.ts (1)

77-78: LGTM! Proper fix for interface consistency.

The addition of displayName and slug correctly addresses the mismatch between the OrganizationReduxState interface (which already defines these fields) and the actual state update in the reducer.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jacquesikot jacquesikot added the ok-to-test Required label for CI label May 27, 2025
@github-actions github-actions bot added the Bug Something isn't working label May 27, 2025
@jacquesikot jacquesikot merged commit 3bcc8b0 into release May 28, 2025
48 checks passed
@jacquesikot jacquesikot deleted the feat/add-display-name-and-slug-to-ce-org-reducer branch May 28, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitakinger ankitakinger ankitakinger approved these changes

@jsartisan jsartisan Awaiting requested review from jsartisan

Assignees

@jacquesikot jacquesikot

Labels
Bug Something isn't working ok-to-test Required label for CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacquesikot @ankitakinger