Skip to content

feat: execute on load backwards compatibility backend changes #40644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2025
Merged

feat: execute on load backwards compatibility backend changes #40644

merged 2 commits into from
May 13, 2025

Conversation

sneha122
Copy link
Contributor

@sneha122 sneha122 commented May 12, 2025 •
edited by github-actions bot
Loading

Description

This PR provides backward compatibility for older actions which do not have runBehaviour property in the DB. When such actions have been configured to be run on page load explicitly, they will get executed as other actions which get set to be run on page load when binding happens.

Steps to reproduce:

  • Create app on production (app.appsmith.com)
  • Create mock db users datasource
  • Create 3 queries, Q1, Q2 and Q3
  • Attach Q1 to table so it runs on page load
  • Change executeOnLoad setting of Q3 to page load
  • Export this app
  • Import this on our DP
  • Observe that Q3 does not run on page load

Fixes #40633
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Datasource, @tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/14979473254
Commit: 5009eb4
Cypress dashboard.
Tags: @tag.Datasource, @tag.Sanity
Spec:

Tue, 13 May 2025 03:57:32 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

@sneha122 sneha122 requested review from ApekshaBhosale, ayushpahwa and a team as code owners May 12, 2025 18:12
@sneha122 sneha122 requested a review from NilanshBansal May 12, 2025 18:12
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 12, 2025

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

62 files out of 171 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Bug Something isn't working Deploy Preview Issues found in Deploy Preview High This issue blocks a user from building or impacts a lot of users Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Integrations Product Issues related to a specific integration Needs Triaging Needs attention from maintainers to triage Query Widgets & IDE Pod All issues related to Query, JS, Eval, Widgets & IDE labels May 12, 2025
@sneha122 sneha122 added ok-to-test Required label for CI and removed Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage Deploy Preview Issues found in Deploy Preview Integrations Product Issues related to a specific integration Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Query Widgets & IDE Pod All issues related to Query, JS, Eval, Widgets & IDE labels May 12, 2025
@sneha122 sneha122 requested review from ankitakinger and removed request for a team, ApekshaBhosale and ayushpahwa May 12, 2025 18:12
@github-actions github-actions bot added the Enhancement New feature or request label May 12, 2025
@github-actions github-actions bot added Bug Something isn't working Deploy Preview Issues found in Deploy Preview High This issue blocks a user from building or impacts a lot of users Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Integrations Product Issues related to a specific integration Needs Triaging Needs attention from maintainers to triage Query Widgets & IDE Pod All issues related to Query, JS, Eval, Widgets & IDE labels May 12, 2025
@sneha122 sneha122 changed the base branch from release to feat/reactive-actions-run-behaviour May 13, 2025 03:10
vivek-appsmith
vivek-appsmith approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@vivek-appsmith vivek-appsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sneha122 sneha122 merged commit 7cd7438 into feat/reactive-actions-run-behaviour May 13, 2025
5 checks passed
@sneha122 sneha122 deleted the feat/executeOnLoad-backwards-compatibility branch May 13, 2025 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivek-appsmith vivek-appsmith vivek-appsmith approved these changes

@NilanshBansal NilanshBansal Awaiting requested review from NilanshBansal

@ankitakinger ankitakinger Awaiting requested review from ankitakinger

Assignees
No one assigned
Labels
Bug Something isn't working Deploy Preview Issues found in Deploy Preview Enhancement New feature or request High This issue blocks a user from building or impacts a lot of users Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Integrations Product Issues related to a specific integration Needs Triaging Needs attention from maintainers to triage ok-to-test Required label for CI Query Widgets & IDE Pod All issues related to Query, JS, Eval, Widgets & IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Older query with page load set explicitly does not get executed with reactive queries changes
2 participants
@sneha122 @vivek-appsmith