chore: downgrade tinymce from 7.7.1 to 6.8.3 in package.json #40465
Conversation
WalkthroughThe change downgrades the "tinymce" dependency in the Changes
Assessment against linked issues
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro (Legacy)
📒 Files selected for processing (1)
app/client/src/widgets/RichTextEditorWidget/component/index.tsx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: perform-test / client-build / client-build
- GitHub Check: perform-test / rts-build / build
- GitHub Check: perform-test / server-build / server-unit-tests
- GitHub Check: client-unit-tests / client-unit-tests
- GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
- GitHub Check: client-lint / client-lint
- GitHub Check: client-build / client-build
- GitHub Check: client-prettier / prettier-check
| text_patterns: [ | ||
| { start: "#", format: "h1", trigger: "space" }, | ||
| { start: "##", format: "h2", trigger: "space" }, | ||
| { start: "###", format: "h3", trigger: "space" }, | ||
| { start: "1.", cmd: "InsertOrderedList", trigger: "space" }, | ||
| { start: "*", cmd: "InsertUnorderedList", trigger: "space" }, | ||
| { start: "-", cmd: "InsertUnorderedList", trigger: "space" }, | ||
| { start: ">", cmd: "mceBlockQuote", trigger: "space" }, | ||
| { start: "#", format: "h1" }, | ||
| { start: "##", format: "h2" }, | ||
| { start: "###", format: "h3" }, | ||
| { start: "1.", cmd: "InsertOrderedList" }, | ||
| { start: "*", cmd: "InsertUnorderedList" }, | ||
| { start: "-", cmd: "InsertUnorderedList" }, | ||
| { start: ">", cmd: "mceBlockQuote" }, | ||
| ], |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
The comment on line 462 might need to be updated to match the implementation
The comment states that text patterns are configured "to use space key trigger", but the implementation no longer specifies a trigger, meaning it will use TinyMCE's default behavior instead of explicitly requiring a space key press. This change is consistent with the TinyMCE downgrade from 7.7.1 to 6.8.3.
- // Configure text patterns to use space key trigger for markdown-style formatting
+ // Configure text patterns for markdown-style formatting🏁 Script executed:
#!/bin/bash
# Check TinyMCE 6.x documentation for default text pattern behavior
rg -A 5 -B 5 "text_patterns" --glob "*.md" || echo "No documentation found for text_patterns in the repository"Length of output: 169
Update comment to reflect default TinyMCE trigger behavior
The existing comment still mentions an explicit “space key trigger,” but since we rely on TinyMCE’s default trigger now, the comment should be adjusted.
• File: app/client/src/widgets/RichTextEditorWidget/component/index.tsx
• Line: 462
- // Configure text patterns to use space key trigger for markdown-style formatting
+ // Configure text patterns for markdown-style formatting📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| text_patterns: [ | |
| { start: "#", format: "h1", trigger: "space" }, | |
| { start: "##", format: "h2", trigger: "space" }, | |
| { start: "###", format: "h3", trigger: "space" }, | |
| { start: "1.", cmd: "InsertOrderedList", trigger: "space" }, | |
| { start: "*", cmd: "InsertUnorderedList", trigger: "space" }, | |
| { start: "-", cmd: "InsertUnorderedList", trigger: "space" }, | |
| { start: ">", cmd: "mceBlockQuote", trigger: "space" }, | |
| { start: "#", format: "h1" }, | |
| { start: "##", format: "h2" }, | |
| { start: "###", format: "h3" }, | |
| { start: "1.", cmd: "InsertOrderedList" }, | |
| { start: "*", cmd: "InsertUnorderedList" }, | |
| { start: "-", cmd: "InsertUnorderedList" }, | |
| { start: ">", cmd: "mceBlockQuote" }, | |
| ], | |
| // Configure text patterns for markdown-style formatting | |
| text_patterns: [ | |
| { start: "#", format: "h1" }, | |
| { start: "##", format: "h2" }, | |
| { start: "###", format: "h3" }, | |
| { start: "1.", cmd: "InsertOrderedList" }, | |
| { start: "*", cmd: "InsertUnorderedList" }, | |
| { start: "-", cmd: "InsertUnorderedList" }, | |
| { start: ">", cmd: "mceBlockQuote" }, | |
| ], |
Description
Following the first proposed option, this PR downgrades the tinymce dependency back to the latest available 6.x version, which is still covered under the MIT license.
This ensures Appsmith remains compliant with its Apache-2.0 licensing terms without needing to replace the editor entirely.
Implementation Details
Additional Notes
Fixes #40365
or
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.Sanity, @tag.RichTextEditor"
🔍 Cypress test results
Warning
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/14723969208
Commit: 9def459
Cypress dashboard.
Tags: @tag.Sanity, @tag.RichTextEditor
Spec:
It seems like no tests ran 😔. We are not able to recognize it, please check workflow here.
Tue, 29 Apr 2025 05:26:36 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit