app/client/packages/design-system/ads/src/Switch/Switch.styles.tsx (1)

34-34: Consider using break-word instead of break-all

word-break: break-all can make text harder to read by breaking words at any point. Consider using word-break: break-word or overflow-wrap: break-word for better readability while still preventing overflow.

-  word-break: break-all;
+  word-break: break-word;

app/client/src/ce/PluginActionEditor/components/PluginActionResponse/hooks/usePluginActionResponseTabs.tsx (1)

114-115: Consider aligning component name with tab title

While the tab has been renamed to "Datasource", it still renders a component named Schema. This might cause confusion during maintenance.

Consider renaming the component to maintain consistency:

- <Schema
+ <DatasourceSchema
    currentActionId={action.id}
    datasourceId={datasource?.id || ""}
    datasourceName={datasource?.name || ""}
  />

Also applies to: 116-122

app/client/src/pages/Editor/DataSourceEditor/Debugger.tsx (1)

Line range hint 122-122: TODO: Move close functionality to common place

The comment indicates a need to refactor the close functionality. This could improve code maintainability.

Would you like me to help create a GitHub issue to track this refactoring task?

app/client/src/pages/Editor/QueryEditor/QueryDebuggerTabs.tsx (1)

220-221: Use createMessage for consistency

Other tab titles in this file use the createMessage utility with message constants. Consider using the same pattern here instead of hardcoding the "Datasource" string.

  key: DEBUGGER_TAB_KEYS.DATASOURCE_TAB,
- title: "Datasource",
+ title: createMessage(DEBUGGER_DATASOURCE),

Configuration used: .coderabbit.yaml
Review profile: CHILL

#!/bin/bash
# Search for any tests covering the debugger tab visibility
rg -A 5 "shouldRender|DATASOURCE_TAB.*visibility" --type test

#!/bin/bash
# Search for test files related to debugger tabs
fd -e test.tsx -e test.ts -e spec.tsx -e spec.ts | grep -i debugger

# Search for any tests covering the debugger tab visibility with proper context
rg -A 5 "shouldRender|DATASOURCE_TAB.*visibility" app/client/src/components/editorComponents/Debugger/

#!/bin/bash
# Let's check the test files for any debugger tab related tests
rg -A 10 "DATASOURCE_TAB|debugger.*tab" app/client/src/pages/Editor/QueryEditor/QueryDebuggerTabs.test.tsx app/client/src/pages/Editor/DataSourceEditor/Debugger.test.tsx

# Let's also check the constants file to verify the tab key definitions
rg "DEBUGGER_TAB_KEYS" -A 5 app/client/src/constants/

#!/bin/bash
# Let's search for the enum definition and its usage
rg -g '*.ts' -g '*.tsx' "enum.*DEBUGGER_TAB_KEYS|type.*DEBUGGER_TAB_KEYS" -A 5

# Let's also check how the DATASOURCE_TAB is used in the codebase
rg -g '*.ts' -g '*.tsx' "DATASOURCE_TAB" -B 2 -A 2

app/client/src/PluginActionEditor/components/PluginActionForm/components/CommonEditorForm/components/EmbeddedDatasourcePathField.tsx (1)

Line range hint 596-604: Consider simplifying the conditional logic and datasourceId assignment

The nested ternary operator for datasourceId could be simplified for better readability. Also, verify if displayValue check is necessary as it might prevent saving in valid cases.

Consider this refactoring:

-        {displayValue && shouldSave && (
+        {shouldSave && (
           <StoreAsDatasource
-            datasourceId={
-              datasourceObject && "id" in datasourceObject
-                ? datasourceObject.id
-                : undefined
-            }
+            datasourceId={datasourceObject?.id}
             enable={isEnabled}
             shouldSave={shouldSave}
           />
         )}

Configuration used: .coderabbit.yaml
Review profile: CHILL

app/client/src/PluginActionEditor/components/PluginActionResponse/components/Schema/DatasourceSelector/ApiDatasourceSelector.tsx (1)

1-13: LGTM! Consider extracting form config to a shared constant.

The Redux Form implementation is clean and type-safe. Since both ApiDatasourceSelector and QueryDatasourceSelector share identical form configuration (except form name), consider extracting the common config to a shared constant.

// Suggested shared config in a separate constants file
export const DATASOURCE_FORM_CONFIG = {
  destroyOnUnmount: false,
  enableReinitialize: true,
};

app/client/src/PluginActionEditor/components/PluginActionResponse/components/Schema/DatasourceSelector/index.tsx (1)

7-10: Consider moving API_FORM_COMPONENTS to constants file.

This array could be reused elsewhere in the application. Consider moving it to a shared constants file for better maintainability.

app/client/src/PluginActionEditor/components/PluginActionResponse/components/Schema/SchemaTables.tsx (1)

87-101: Enhance button accessibility.

The edit button should include proper accessibility attributes:

 <Button
   isIconButton
   kind="tertiary"
   onClick={editDatasource}
   size="sm"
   startIcon="datasource-config"
+  aria-label="Edit datasource configuration"
 />

Configuration used: .coderabbit.yaml
Review profile: CHILL

-formName={
-  plugin?.type === PluginType.API
-    ? API_EDITOR_FORM_NAME
-    : QUERY_EDITOR_FORM_NAME
-}
+formName={plugin?.type === PluginType.API ? API_EDITOR_FORM_NAME : QUERY_EDITOR_FORM_NAME}

app/server/appsmith-server/src/main/java/com/appsmith/server/migrations/db/ce/Migration064AddPluginDocUrlToRestApiPlugin.java (1)

23-24: Consider implementing rollback logic

The empty rollback method might pose risks if the migration needs to be reverted.

Consider implementing the rollback by removing the documentationLink field:

@RollbackExecution
public void rollbackExecution() {
+    Query query = new Query().addCriteria(Criteria.where("packageName").is("restapi-plugin"));
+    Update update = new Update().unset("documentationLink");
+    mongoTemplate.updateMulti(query, update, Plugin.class);
}

Configuration used: .coderabbit.yaml
Review profile: CHILL

#!/bin/bash
# Check for migration order conflicts
fd --type f --glob "*Migration*.java" | xargs grep -l "@ChangeUnit" | xargs grep "order ="

#!/bin/bash
# Check if the documentation URL is referenced elsewhere
rg -l "docs.appsmith.com/connect-data/reference/rest-api"

#!/bin/bash
# Check for documentation URLs in config files and docs
rg -i "docs\.appsmith\.com" --type yaml --type md --type json

# Check if there are other documentation links for plugins
rg "documentationLink.*docs\.appsmith\.com" -A 2

#!/bin/bash
# Use curl to check if the documentation URL is accessible
curl -I https://docs.appsmith.com/connect-data/reference/rest-api

app/client/cypress/e2e/Sanity/Datasources/GraphQL_spec.ts (3)

Line range hint 308-341: Remove agHelper.Sleep() calls and improve selector usage

The code has several areas that can be improved to align with our Cypress best practices:

1. Remove explicit sleep calls and use proper Cypress wait mechanisms
2. Use data-* attributes instead of text selectors
3. Combine multiple assertions into single expect statements where possible

Here's the suggested improvement:

  apiPage.RunAPI();
  apiPage.SelectPaneTab("Authentication");
  agHelper.GetNClick(locators._saveDatasource);
  dataSources.AssertDataSourceInfo([
    dataManager.dsValues[
      dataManager.defaultEnviorment
    ].GraphqlApiUrl_TED.replace("/graphql", ""),
    "content-type",
    "application/json",
    "No",
  ]);
  agHelper.ClickButton("Edit");
- dataSources.ValidateNSelectDropdown(
-   "Authentication type",
-   "None",
-   "OAuth 2.0",
- );
+ // Add data-cy attribute to the dropdown and use it
+ cy.get('[data-cy="auth-type-dropdown"]')
+   .should('contain', 'None')
+   .click()
+   .get('[data-cy="dropdown-oauth"]')
+   .click();

- propPane.AssertPropertiesDropDownValues("Grant type", [
-   "Client Credentials",
-   "Authorization Code",
- ]);
+ // Combine assertions for dropdown values
+ cy.get('[data-cy="grant-type-dropdown"]').within(() => {
+   cy.get('option').should(($options) => {
+     expect($options).to.have.length(2);
+     expect($options.eq(0)).to.contain('Client Credentials');
+     expect($options.eq(1)).to.contain('Authorization Code');
+   });
+ });

  // For Client Credentials Grant Type, the button should be Save
  // Default first selection from dropdown is Client Credentials
  assertHelper.AssertContains("Save", "exist", dataSources._saveDs);

- propPane.AssertPropertiesDropDownValues("Add Access Token To", [
-   "Request Header",
-   "Request Header",
- ]);
+ // Combine assertions for token dropdown
+ cy.get('[data-cy="token-location-dropdown"]').within(() => {
+   cy.get('option').should(($options) => {
+     expect($options).to.have.length(2);
+     expect($options).to.have.value('header');
+   });
+ });

- agHelper.AssertElementVisibility(
-   locators._visibleTextDiv("Datasource not authorized"),
- );
+ // Use data attribute for unauthorized message
+ cy.get('[data-cy="ds-unauthorized-message"]')
+   .should('be.visible')
+   .and('contain', 'Datasource not authorized');

---

Line range hint 376-377: Replace agHelper.Sleep with proper Cypress wait mechanisms

Using explicit sleep calls is against best practices and can make tests flaky.

- agHelper.Sleep(2000);
+ cy.wait('@postExecute').its('response.statusCode').should('eq', 200);

---

Line range hint 1-401: Add type definitions for better code maintainability

The test file would benefit from TypeScript type definitions for the API responses and data structures.

Add these type definitions at the top of the file:

interface GraphQLResponse {
  data: {
    body: {
      data?: any;
      errors?: Array<{
        message: string;
      }>;
    };
    isExecutionSuccess: boolean;
  };
}

interface PostExecuteInterception {
  response: {
    body: GraphQLResponse;
    statusCode: number;
  };
}

app/client/cypress/e2e/Regression/ClientSide/BugTests/DS_Bug25148_Spec.ts (1)

Line range hint 1-27: Improve test structure and maintainability.

Consider these structural improvements:

1. Move UUID generation to a before hook
2. Add cleanup in an after hook
3. Use constants instead of global variables

 import * as _ from "../../../../support/Objects/ObjectsCore";
 
 const { agHelper, apiPage, dataSources } = _;
-let dsName: any;
 
 describe(
   "Bug 25148 - Edit Datasource button was disabled on Authentication tab of Api action",
   { tags: ["@tag.Datasource", "@tag.Git", "@tag.AccessControl"] },
   () => {
+    let dsName: string;
+    
+    beforeEach(() => {
+      agHelper.GenerateUUID();
+      cy.get("@guid").then((uid) => {
+        dsName = `AuthAPI ${uid}`;
+      });
+    });
+    
+    afterEach(() => {
+      // Clean up created datasource
+      dataSources.DeleteDatasourceFromWithinDS(dsName);
+    });
+    
     it("1. Checking if the Edit datasource button is enabled or not", () => {
       dataSources.NavigateToDSCreateNew();
-      agHelper.GenerateUUID();
-      cy.get("@guid").then((uid) => {
-        dsName = "AuthAPI " + uid;
-        dataSources.CreatePlugIn("Authenticated API");
-        agHelper.RenameDatasource(dsName);
+      dataSources.CreatePlugIn("Authenticated API");
+      agHelper.RenameDatasource(dsName);

Configuration used: .coderabbit.yaml
Review profile: CHILL

app/client/src/pages/Editor/IDE/EditorPane/Query/QueryRender.test.tsx (3)

332-341: Extract duplicate mockPlugin definitions

Consider refactoring the mockPlugin definitions into a shared utility or helper function to avoid code duplication and enhance maintainability.

---

421-423: Reduce repetition in component wrapping

Consider creating a helper function for wrapping <IDE /> with PluginActionContextProvider to reduce code repetition across tests.

---

554-563: Extract duplicate mockPlugin definitions

Similar to the earlier mockPlugin for Postgres, extracting this mockPlugin for Google Sheets into a shared utility can minimize code duplication.

Configuration used: .coderabbit.yaml
Review profile: CHILL