Skip to content

Revert "fix: Add pane issues (#33627)" #33687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2024
Merged

Revert "fix: Add pane issues (#33627)" #33687

merged 1 commit into from
May 23, 2024

Conversation

rahulbarwal
Copy link
Contributor

@rahulbarwal rahulbarwal commented May 23, 2024 •
edited by github-actions bot
Loading

Description

This reverts commit f93410e.

#33627

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.ImportExport"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9203923153
Commit: 2da6d7e
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 23, 2024 •
edited
Loading

Walkthrough

Walkthrough

The recent updates enhance the user interface and functionality within the application. Key changes include refining the grouping logic for entity items based on plugin types, enhancing padding styles in various components for better layout, and cleaning up test files by removing obsolete mock data setups. These adjustments aim to improve the clarity and usability of the UI, along with streamlining the codebase.

Changes

File Path Change Summary
app/client/src/ce/selectors/entitiesSelector.ts Modified grouping logic for entity items to distinguish between API and AI plugins more clearly.
app/client/src/pages/Editor/IDE/EditorPane/JS/Add.tsx
app/client/src/pages/Editor/IDE/EditorPane/Query/Add.tsx		 Added padding style p="spaces-3" to AddJS and AddQuery components.
app/client/src/pages/Editor/IDE/EditorPane/Query/QueryRender.test.tsx Removed references to datasourceFactory and related mock data setup for Postgres and Google Sheets routes.
app/client/src/pages/Editor/IDE/EditorPane/components/SegmentAddHeader.tsx Modified layout styling properties for Flex component to include padding on various sides.
Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 0f167af and 2da6d7e.
Files selected for processing (5)
  • app/client/src/ce/selectors/entitiesSelector.ts (1 hunks)
  • app/client/src/pages/Editor/IDE/EditorPane/JS/Add.tsx (1 hunks)
  • app/client/src/pages/Editor/IDE/EditorPane/Query/Add.tsx (1 hunks)
  • app/client/src/pages/Editor/IDE/EditorPane/Query/QueryRender.test.tsx (13 hunks)
  • app/client/src/pages/Editor/IDE/EditorPane/components/SegmentAddHeader.tsx (1 hunks)
Files skipped from review due to trivial changes (2)
  • app/client/src/pages/Editor/IDE/EditorPane/Query/Add.tsx
  • app/client/src/pages/Editor/IDE/EditorPane/Query/QueryRender.test.tsx
Additional comments not posted (3)
app/client/src/pages/Editor/IDE/EditorPane/components/SegmentAddHeader.tsx (1)

14-16: Padding adjustments align with the design system's spacing scale and enhance component layout.

app/client/src/pages/Editor/IDE/EditorPane/JS/Add.tsx (1)

46-46: Ensure the new padding does not affect the responsiveness or alignment of child components.

app/client/src/ce/selectors/entitiesSelector.ts (1)

1502-1525: Updated grouping logic in getQuerySegmentItems enhances clarity by distinguishing between API and AI plugins.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rahulbarwal rahulbarwal self-assigned this May 23, 2024
@rahulbarwal rahulbarwal added the ok-to-test Required label for CI label May 23, 2024
@rahulbarwal rahulbarwal added IDE Navigation Issues/feature requests related to IDE navigation, and context switching Partial-import-export Label for granular reusability. labels May 23, 2024
@trishaanand trishaanand merged commit dd6daa4 into release May 23, 2024
@trishaanand trishaanand deleted the fix/test-partialimport-failure branch May 23, 2024 07:50
@rahulbarwal rahulbarwal added Templates Product Issues related to Templates Templates labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trishaanand trishaanand trishaanand approved these changes

@hetunandu hetunandu Awaiting requested review from hetunandu

Assignees

@rahulbarwal rahulbarwal

Labels
IDE Navigation Issues/feature requests related to IDE navigation, and context switching ok-to-test Required label for CI Partial-import-export Label for granular reusability. Templates Product Issues related to Templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahulbarwal @trishaanand