Skip to content

fix: table version changed for crud #29457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Dec 29, 2023
Merged

fix: table version changed for crud #29457

merged 37 commits into from
Dec 29, 2023

Conversation

AmanAgarwal041
Copy link
Contributor

@AmanAgarwal041 AmanAgarwal041 commented Dec 8, 2023 •
edited
Loading

Description

Following are the changes that this PR introduces :

  • Earlier the generate crud operation was using Table widget version v1 with the help of CRUD-DB-Table-Template-Application.json which is now changed to Table widget version v2 after this change
  • Test cases that were present using the generate crud have now been changed to support Table v2 version.

PR fixes following issue(s)

Fixes #29567

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (housekeeping or task changes that don't impact user perception)
  • This change requires a documentation update

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

  • Manual
  • JUnit
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Speedbreak features have been covered
  • Test plan covers all impacted features and areas of interest
  • Test plan has been peer reviewed by project stakeholders and other QA members
  • Manually tested functionality on DP
  • We had an implementation alignment call with stakeholders post QA Round 2
  • Cypress test cases have been added and approved by SDET/manual QA
  • Added Test Plan Approved label after Cypress tests were reviewed
  • Added Test Plan Approved label after JUnit tests were reviewed

Summary by CodeRabbit

  • Tests

    • Updated Cypress end-to-end test scripts to align with the version change from "v1" to "v2" for various modules and components.
    • Enhanced data validation and refined deployment workflow in test cases.
    • Adjusted test scripts to account for updated control flow and interaction with table components.

  • Refactor

    • Modified table column rendering logic to prioritize new column IDs.

  • Chores

    • Standardized the use of "click" actions in Cypress support files to improve consistency and reliability in automated tests.

@AmanAgarwal041 AmanAgarwal041 marked this pull request as draft December 8, 2023 06:21
@AmanAgarwal041
Copy link
Contributor Author

/ok-to-test

@github-actions github-actions bot added the Bug Something isn't working label Dec 8, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7138135000.
Workflow: Appsmith External Integration Test Workflow.
Tags: ``.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7138135000.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/BugTests/Bug9334_Spec.ts

  2. cypress/e2e/Regression/ClientSide/Git/GitSync/GitSyncedApps_spec.js
  3. cypress/e2e/Regression/ServerSide/GenerateCRUD/MongoURI_Spec.ts
  4. cypress/e2e/Regression/ServerSide/GenerateCRUD/Mongo_Spec.ts
  5. cypress/e2e/Regression/ServerSide/GenerateCRUD/MySQL1_Spec.ts
  6. cypress/e2e/Regression/ServerSide/GenerateCRUD/MySQL2_Spec.ts
  7. cypress/e2e/Regression/ServerSide/GenerateCRUD/Postgres1_Spec.ts
  8. cypress/e2e/Regression/ServerSide/GenerateCRUD/Postgres2_Spec.ts
  9. cypress/e2e/Regression/ServerSide/QueryPane/Mongo1_spec.ts
  10. cypress/e2e/Regression/ServerSide/QueryPane/Mongo_Spec.js
  11. cypress/e2e/Regression/ServerSide/QueryPane/Postgres_Spec.js
  12. cypress/e2e/Regression/ServerSide/QueryPane/S3_2_spec.ts
To know the list of identified flaky tests - Refer here

@AmanAgarwal041
Copy link
Contributor Author

/ok-to-test

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7163565123.
Workflow: Appsmith External Integration Test Workflow.
Tags: ``.

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7163565123.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Binding/TableTextPagination_spec.js

  2. cypress/e2e/Regression/ClientSide/BugTests/Bug9334_Spec.ts
  3. cypress/e2e/Regression/ClientSide/BugTests/Moment_Spec.ts
  4. cypress/e2e/Regression/ClientSide/Git/GitImport/GitImport_spec.js
  5. cypress/e2e/Regression/ClientSide/Widgets/List/List4_1_spec.ts
  6. cypress/e2e/Regression/ClientSide/Widgets/TableV1/TableFilter1_1_Spec.ts
  7. cypress/e2e/Regression/ClientSide/Widgets/TableV1/TableFilter1_2_Spec.ts
  8. cypress/e2e/Regression/ClientSide/Widgets/TableV1/TableFilter2_1_Spec.ts
  9. cypress/e2e/Regression/ClientSide/Widgets/TableV1/Table_PropertyPane_2_spec.js
  10. cypress/e2e/Regression/ServerSide/GenerateCRUD/MongoURI_Spec.ts
  11. cypress/e2e/Regression/ServerSide/GenerateCRUD/Mongo_Spec.ts
  12. cypress/e2e/Regression/ServerSide/GenerateCRUD/MySQL1_Spec.ts
  13. cypress/e2e/Regression/ServerSide/GenerateCRUD/MySQL2_Spec.ts
  14. cypress/e2e/Regression/ServerSide/GenerateCRUD/Postgres1_Spec.ts
  15. cypress/e2e/Regression/ServerSide/GenerateCRUD/Postgres2_Spec.ts
  16. cypress/e2e/Regression/ServerSide/JsFunctionExecution/JSFunctionExecution_spec.ts
  17. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Binary_Spec.ts
  18. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Character_Spec.ts
  19. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/DateTime_Spec.ts
  20. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Json_Spec.ts
  21. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Numeric_Spec.ts
  22. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/UUID_Spec.ts
  23. cypress/e2e/Regression/ServerSide/QueryPane/Mongo1_spec.ts
  24. cypress/e2e/Regression/ServerSide/QueryPane/Mongo_Spec.js
  25. cypress/e2e/Regression/ServerSide/QueryPane/Postgres_Spec.js
To know the list of identified flaky tests - Refer here

@AmanAgarwal041
Copy link
Contributor Author

/ok-to-test

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7192976425.
Workflow: Appsmith External Integration Test Workflow.
Tags: ``.

@github-actions github-actions bot added Data Platform Pod Issues related to the underlying data platform Datasources Issues related to configuring datasource on appsmith Needs Triaging Needs attention from maintainers to triage labels Dec 13, 2023
@AmanAgarwal041
Copy link
Contributor Author

This is a draft pr to try out the updation of table version for generate crud functionality after looking into the previously closed issue as well as pr and some conversation behind that decision. Here are my observations :

  • There is just the backend change in app/server/appsmith-server/src/main/resources/CRUD-DB-Table-Template-Application.json file to enable the usage of table version v2 for generate crud functionality
  • We need to look into the different failing test cases that are still using table v1 to verify the working application
  • We need to remove the table version v1 specific test cases from the repo

@AmanAgarwal041 AmanAgarwal041 mentioned this pull request Dec 13, 2023
Closed
1 task
@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7192976425.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Binding/SelectWidget_Spec.ts

  2. cypress/e2e/Regression/ClientSide/Binding/TableTextPagination_spec.js
  3. cypress/e2e/Regression/ClientSide/BugTests/Bug9334_Spec.ts
  4. cypress/e2e/Regression/ClientSide/BugTests/Moment_Spec.ts
  5. cypress/e2e/Regression/ClientSide/Git/GitImport/GitImport_spec.js
  6. cypress/e2e/Regression/ClientSide/Widgets/List/List4_1_spec.ts
  7. cypress/e2e/Regression/ClientSide/Widgets/TableV1/TableBugs_Spec.ts
  8. cypress/e2e/Regression/ClientSide/Widgets/TableV1/TableFilter1_1_Spec.ts
  9. cypress/e2e/Regression/ClientSide/Widgets/TableV1/TableFilter1_2_Spec.ts
  10. cypress/e2e/Regression/ClientSide/Widgets/TableV1/TableFilter2_1_Spec.ts
  11. cypress/e2e/Regression/ClientSide/Widgets/TableV1/TableFilter2_2_Spec.ts
  12. cypress/e2e/Regression/ClientSide/Widgets/TableV1/Table_PropertyPane_2_spec.js
  13. cypress/e2e/Regression/ServerSide/GenerateCRUD/MongoURI_Spec.ts
  14. cypress/e2e/Regression/ServerSide/GenerateCRUD/Mongo_Spec.ts
  15. cypress/e2e/Regression/ServerSide/GenerateCRUD/MySQL1_Spec.ts
  16. cypress/e2e/Regression/ServerSide/GenerateCRUD/MySQL2_Spec.ts
  17. cypress/e2e/Regression/ServerSide/GenerateCRUD/Postgres1_Spec.ts
  18. cypress/e2e/Regression/ServerSide/GenerateCRUD/Postgres2_Spec.ts
  19. cypress/e2e/Regression/ServerSide/JsFunctionExecution/JSFunctionExecution_spec.ts
  20. cypress/e2e/Regression/ServerSide/OnLoadTests/JSOnLoad1_Spec.ts
  21. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Binary_Spec.ts
  22. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Character_Spec.ts
  23. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/DateTime_Spec.ts
  24. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Json_Spec.ts
  25. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Numeric_Spec.ts
  26. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/UUID_Spec.ts
  27. cypress/e2e/Regression/ServerSide/QueryPane/Mongo1_spec.ts
  28. cypress/e2e/Regression/ServerSide/QueryPane/Mongo_Spec.js
  29. cypress/e2e/Regression/ServerSide/QueryPane/Postgres_Spec.js
To know the list of identified flaky tests - Refer here

@sneha122
Copy link
Contributor

/ok-to-test

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7247072552.
Workflow: Appsmith External Integration Test Workflow.
Tags: ``.

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7247072552.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/AdminSettings/Admin_settings_spec.js

  2. cypress/e2e/Regression/ClientSide/Binding/SelectWidget_Spec.ts
  3. cypress/e2e/Regression/ClientSide/Binding/TableTextPagination_spec.js
  4. cypress/e2e/Regression/ClientSide/BugTests/Bug9334_Spec.ts
  5. cypress/e2e/Regression/ClientSide/BugTests/Moment_Spec.ts
  6. cypress/e2e/Regression/ClientSide/Git/GitImport/GitImport_spec.js
  7. cypress/e2e/Regression/ClientSide/Widgets/List/List4_1_spec.ts
  8. cypress/e2e/Regression/ClientSide/Widgets/TableV1/TableBugs_Spec.ts
  9. cypress/e2e/Regression/ClientSide/Widgets/TableV1/TableFilter1_1_Spec.ts
  10. cypress/e2e/Regression/ClientSide/Widgets/TableV1/TableFilter1_2_Spec.ts
  11. cypress/e2e/Regression/ClientSide/Widgets/TableV1/TableFilter2_1_Spec.ts
  12. cypress/e2e/Regression/ClientSide/Widgets/TableV1/TableFilter2_2_Spec.ts
  13. cypress/e2e/Regression/ClientSide/Widgets/TableV1/Table_PropertyPane_2_spec.js
  14. cypress/e2e/Regression/ServerSide/GenerateCRUD/MongoURI_Spec.ts
  15. cypress/e2e/Regression/ServerSide/GenerateCRUD/Mongo_Spec.ts
  16. cypress/e2e/Regression/ServerSide/GenerateCRUD/MySQL1_Spec.ts
  17. cypress/e2e/Regression/ServerSide/GenerateCRUD/MySQL2_Spec.ts
  18. cypress/e2e/Regression/ServerSide/GenerateCRUD/Postgres1_Spec.ts
  19. cypress/e2e/Regression/ServerSide/GenerateCRUD/Postgres2_Spec.ts
  20. cypress/e2e/Regression/ServerSide/JsFunctionExecution/JSFunctionExecution_spec.ts
  21. cypress/e2e/Regression/ServerSide/MySQL_Datatypes/Basic_Spec.ts
  22. cypress/e2e/Regression/ServerSide/OnLoadTests/JSOnLoad1_Spec.ts
  23. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Array_Spec.ts
  24. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Binary_Spec.ts
  25. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/BooleanEnum_Spec.ts
  26. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Character_Spec.ts
  27. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/DateTime_Spec.ts
  28. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Json_Spec.ts
  29. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Numeric_Spec.ts
  30. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/UUID_Spec.ts
  31. cypress/e2e/Regression/ServerSide/QueryPane/Mongo1_spec.ts
  32. cypress/e2e/Regression/ServerSide/QueryPane/Mongo_Spec.js
  33. cypress/e2e/Regression/ServerSide/QueryPane/Postgres_Spec.js
To know the list of identified flaky tests - Refer here

@sneha122
Copy link
Contributor

/ok-to-test

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7260774125.
Workflow: Appsmith External Integration Test Workflow.
Tags: ``.

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7260774125.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/AdminSettings/Admin_settings_spec.js

  2. cypress/e2e/Regression/ClientSide/Binding/SelectWidget_Spec.ts
  3. cypress/e2e/Regression/ClientSide/Binding/TableTextPagination_spec.js
  4. cypress/e2e/Regression/ClientSide/BugTests/Bug9334_Spec.ts
  5. cypress/e2e/Regression/ClientSide/BugTests/Moment_Spec.ts
  6. cypress/e2e/Regression/ClientSide/Git/GitImport/GitImport_spec.js
  7. cypress/e2e/Regression/ClientSide/OtherUIFeatures/UpdateApplication_spec.js
  8. cypress/e2e/Regression/ClientSide/Widgets/List/List4_1_spec.ts
  9. cypress/e2e/Regression/ClientSide/Widgets/TableV1/TableBugs_Spec.ts
  10. cypress/e2e/Regression/ClientSide/Widgets/TableV1/TableFilter1_1_Spec.ts
  11. cypress/e2e/Regression/ClientSide/Widgets/TableV1/TableFilter1_2_Spec.ts
  12. cypress/e2e/Regression/ClientSide/Widgets/TableV1/TableFilter2_1_Spec.ts
  13. cypress/e2e/Regression/ClientSide/Widgets/TableV1/TableFilter2_2_Spec.ts
  14. cypress/e2e/Regression/ClientSide/Widgets/TableV1/Table_PropertyPane_2_spec.js
  15. cypress/e2e/Regression/ClientSide/Workspace/WorkspaceImportApplication_spec.js
  16. cypress/e2e/Regression/ServerSide/GenerateCRUD/MongoURI_Spec.ts
  17. cypress/e2e/Regression/ServerSide/GenerateCRUD/Mongo_Spec.ts
  18. cypress/e2e/Regression/ServerSide/GenerateCRUD/MySQL1_Spec.ts
  19. cypress/e2e/Regression/ServerSide/GenerateCRUD/MySQL2_Spec.ts
  20. cypress/e2e/Regression/ServerSide/GenerateCRUD/Postgres1_Spec.ts
  21. cypress/e2e/Regression/ServerSide/GenerateCRUD/Postgres2_Spec.ts
  22. cypress/e2e/Regression/ServerSide/JsFunctionExecution/JSFunctionExecution_spec.ts
  23. cypress/e2e/Regression/ServerSide/MySQL_Datatypes/Basic_Spec.ts
  24. cypress/e2e/Regression/ServerSide/OnLoadTests/JSOnLoad1_Spec.ts
  25. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Array_Spec.ts
  26. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Binary_Spec.ts
  27. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/BooleanEnum_Spec.ts
  28. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Character_Spec.ts
  29. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/DateTime_Spec.ts
  30. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Json_Spec.ts
  31. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Numeric_Spec.ts
  32. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/UUID_Spec.ts
  33. cypress/e2e/Regression/ServerSide/QueryPane/Mongo1_spec.ts
  34. cypress/e2e/Regression/ServerSide/QueryPane/Mongo_Spec.js
  35. cypress/e2e/Regression/ServerSide/QueryPane/Postgres_Spec.js
To know the list of identified flaky tests - Refer here

@AmanAgarwal041
Copy link
Contributor Author

/ok-to-test tags="@tag.All"

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7349942567.
Workflow: Appsmith External Integration Test Workflow.
Tags: ``.

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7349942567.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2_tabledata_schema_spec.js

  2. cypress/e2e/Regression/ServerSide/GenerateCRUD/MySQL2_Spec.ts
To know the list of identified flaky tests - Refer here

@AmanAgarwal041
Copy link
Contributor Author

/ok-to-test tags="@tag.All"

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7350621186.
Workflow: Appsmith External Integration Test Workflow.
Tags: ``.

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7350621186.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@AmanAgarwal041
Copy link
Contributor Author

/ok-to-test tags="@tag.All"

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7354902716.
Workflow: Appsmith External Integration Test Workflow.
Tags: ``.

riodeuno
riodeuno previously approved these changes Dec 29, 2023
View reviewed changes
@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7354902716.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Onboarding/GuidedTour_spec.js

To know the list of identified flaky tests - Refer here

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7354902716.
Commit: ``.
Cypress dashboard url: Click here!
It seems like there are some failures 😔. We are not able to recognize it, please check this manually here.

@AmanAgarwal041
Copy link
Contributor Author

/ok-to-test tags="@tag.All"

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7355365411.
Workflow: Appsmith External Integration Test Workflow.
Tags: ``.

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7355365411.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@AmanAgarwal041
Copy link
Contributor Author

/ok-to-test tags="@tag.All"

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7355991007.
Workflow: Appsmith External Integration Test Workflow.
Tags: ``.

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7355991007.
Commit: ``.
Cypress dashboard url: Click here!
It seems like there are some failures 😔. We are not able to recognize it, please check this manually here.

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7355991007.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@AmanAgarwal041 AmanAgarwal041 merged commit fdf25be into release Dec 29, 2023
@AmanAgarwal041 AmanAgarwal041 deleted the fix/crud-table-version branch December 29, 2023 12:19
@ApekshaBhosale ApekshaBhosale mentioned this pull request May 8, 2024
Merged
2 tasks
trishaanand pushed a commit that referenced this pull request May 10, 2024
@ApekshaBhosale
test: GitSyncedApps_spec - multiple IA changes (#33257)
d88b431 
## Description
In this spec, IA changes were required.
1. table version change ---
#29457
2. page related functionalities addition and replacement ie clone, hide
and show list to assert a page name
3. replaced as many as possible git related functionalities to gitSync
helpers


Link - **9th Spec** in
https://www.notion.so/appsmith/Cypress-tests-analysis-4090efa5e3064a2e87f262d3c399a339
**Phase 1**

EE - PR for runs -appsmithorg/appsmith-ee#4140
EE run -- for Git and AccessControl tags
https://github.com/appsmithorg/appsmith-ee/actions/runs/9002744046


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@riodeuno riodeuno riodeuno approved these changes

+1 more reviewer

@sneha122 sneha122 sneha122 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Bug Something isn't working Data Platform Pod Issues related to the underlying data platform Datasources Issues related to configuring datasource on appsmith Generate Page Issures related to page generation Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Product Issues related to a specific integration Needs Triaging Needs attention from maintainers to triage
Projects
Data Platform Pod
Status: Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Update the table version to v2 for generate CRUD functionality
3 participants
@AmanAgarwal041 @sneha122 @riodeuno