bug: fix the false alarm of verification with jwt.WithJSONNumber #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @appleboy |
|
any comments on this? |
appleboy
approved these changes
Dec 1, 2022
|
LGTM @panjf2000 Thanks. |
|
@panjf2000 sorry for the late response. |
|
Could you set up a new release for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation doesn't handle
jwt.WithJSONNumber()parse option well, if you set this option and try to parse a JWT, it always fails type conversion here:gin-jwt/auth_jwt.go
Lines 430 to 433 in 6b68cb3
We should also take care of the type
json.Numberand avoid the false alarm, this is also what https://github.com/golang-jwt/jwt/blob/main/map_claims.go#L40-L56 does.