Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: apple/swift-openapi-generator
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.5.1
Choose a base ref
...
head repository: apple/swift-openapi-generator
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.6.0
Choose a head ref
  • 5 commits
  • 68 files changed
  • 6 contributors

Commits on Dec 11, 2024

  1. Use self for member access/assignment in all initializers, decoders, …

    …and encoders (#700)
    
    ### Motivation
    
    In order to address #695 we made some targeted fixes (#696, #699) to use
    explicit-self to avoid clashing with schema property names. This
    addressed a clash with a specific variable with properties of only
    certain schemas, but there are more places where we might encounter
    future issues. Specifically, we have other variable names which might
    cause a clash (e.g. `storage` and `discriminator`), and there are other
    flavours of initializers, encoders, and decoders that were not updated
    in the targeted fix.
    
    In this PR, we update all access and assignment in the generated code
    dealing with schemas to use explicit-self.
    
    
    ### Modifications
    
    - Use self for member access and assignment in all initializers,
    decoders, and encoders.
    - Update the reference tests and snippet tests.
    
    ### Result
    
    Removed some cases where valid OpenAPI docs would produce non-compiling
    code.
    
    ### Test Plan
    
    Snippet and reference tests. The latter is actually compiled during the
    CI.
    simonjbeaumont authored Dec 11, 2024
    Configuration menu
    Copy the full SHA
    5dd8d18 View commit details
    Browse the repository at this point in the history
  2. Enable MemberImportVisibility check on all targets (#694)

    Enable MemberImportVisibility check on all targets. Use a standard
    string header and footer to bracket the new block for ease of updating
    in the future with scripts.
    rnro authored Dec 11, 2024
    Configuration menu
    Copy the full SHA
    3f83ef7 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2024

  1. Configuration menu
    Copy the full SHA
    a5052b9 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2024

  1. Update release.yml (#705)

    Update the release.yml file with the latest label changes
    FranzBusch authored Dec 18, 2024
    Configuration menu
    Copy the full SHA
    4d0c02d View commit details
    Browse the repository at this point in the history
  2. Idiomatic naming strategy as opt-in (#679)

    ### Motivation
    
    Implementation of #683.
    
    ### Modifications
    
    - Implemented the SOAR-0013 idiomatic naming strategy
    - Added name overrides
    - Switched most reference tests to use the new strategy
    - Updated some docs (I'll update the rest after this lands and gets
    released, then I can update Examples and IntegrationTest)
    
    ### Result
    
    SOAR-0013 implemented.
    
    ### Test Plan
    
    Updated and added new unit tests.
    
    ---------
    
    Co-authored-by: Si Beaumont <simonjbeaumont@gmail.com>
    Co-authored-by: Si Beaumont <beaumont@apple.com>
    3 people authored Dec 18, 2024
    Configuration menu
    Copy the full SHA
    ad7f0e7 View commit details
    Browse the repository at this point in the history
Loading