feat(base-driver): Remove dependency to validate.js #21175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mykola-mokhnach merged 12 commits into appium:appium3 from mykola-mokhnach:validators

Apr 4, 2025

Collaborator

mykola-mokhnach commented Apr 3, 2025

Related to #21171


          feat(base-driver): Remove dependency to validate.js

90fddb1

mykola-mokhnach requested review from KazuCocoa and eglitise

April 3, 2025 19:19

mykola-mokhnach added 2 commits

April 3, 2025 22:11


          Update tests

e253995


          moar

b4289ab

eglitise reviewed

View reviewed changes

packages/base-driver/lib/basedriver/validation.ts Outdated Show resolved Hide resolved

eglitise reviewed

View reviewed changes

packages/base-driver/test/unit/basedriver/capability.spec.js Outdated Show resolved Hide resolved

eglitise reviewed

View reviewed changes

packages/appium/scripts/parse-yml-commands.js Outdated Show resolved Hide resolved

eglitise reviewed

View reviewed changes

packages/appium/scripts/parse-yml-commands.js Outdated Show resolved Hide resolved

eglitise reviewed

View reviewed changes

packages/appium/scripts/parse-yml-commands.js Show resolved Hide resolved

eglitise reviewed

View reviewed changes

packages/base-driver/lib/basedriver/validation.ts Outdated Show resolved Hide resolved

mykola-mokhnach added 6 commits

April 4, 2025 08:38


          Address comments

a2a239f


          Address comments

5c8a901


          no quotes

aa0d88c


          naming

0af7615


          moar

730c779


          update tests

86cb3f9

eglitise reviewed

View reviewed changes

packages/base-driver/lib/basedriver/validation.ts Outdated Show resolved Hide resolved


          address comments

8f8e3ed

KazuCocoa approved these changes

View reviewed changes

Member

KazuCocoa left a comment

lgtm overall

eglitise reviewed

View reviewed changes

packages/base-driver/lib/basedriver/validation.ts Outdated Show resolved Hide resolved


          typos

12c92c2

eglitise reviewed

View reviewed changes

packages/appium/scripts/parse-yml-commands.js Outdated Show resolved Hide resolved


          moar

2e5f0f5

eglitise approved these changes

View reviewed changes

mykola-mokhnach merged commit 661c5d0 into appium:appium3

5 checks passed

mykola-mokhnach deleted the validators branch

April 4, 2025 20:28

KazuCocoa mentioned this pull request

validate.js Regular Expression Denial of Service vulnerability #21171

Closed

2 tasks

eglitise mentioned this pull request

[Feat]: Appium 3 🚀 #20792

Open

20 tasks

eglitise added the v3 label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v3