Skip to content

chore: configure monorepo for appium3 #20790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 16, 2024
Merged

chore: configure monorepo for appium3 #20790

merged 2 commits into from
Dec 16, 2024

Conversation

jlipps
Copy link
Member

@jlipps jlipps commented Nov 29, 2024

No description provided.

KazuCocoa
KazuCocoa reviewed Nov 29, 2024
View reviewed changes
@KazuCocoa KazuCocoa mentioned this pull request Nov 29, 2024
Open
20 tasks
@jlipps
Copy link
Member Author

jlipps commented Dec 7, 2024

Looks like CI is blocked on appium/appium-uiautomator2-driver#846

@eglitise eglitise changed the title configure monorepo for appium3 chore: configure monorepo for appium3 Dec 7, 2024
@KazuCocoa
Copy link
Member

we should ignore them?

  1) Config
       node.js config
         checkNodeOk
           supported nodes
             should succeed if node is 14.17+:
     AssertionError: expected [Function checkNodeOk] to not throw an error but 'Error: Node version must be at least …' was thrown
      at Context.<anonymous> (test/unit/config.spec.js:155:39)
      at processImmediate (node:internal/timers:483:21)
      at process.topLevelDomainCallback (node:domain:161:15)
      at process.callbackTrampoline (node:internal/async_hooks:128:24)

  2) Config
       node.js config
         checkNodeOk
           supported nodes
             should succeed if node is 16.13+:
     AssertionError: expected [Function checkNodeOk] to not throw an error but 'Error: Node version must be at least …' was thrown
      at Context.<anonymous> (test/unit/config.spec.js:160:39)
      at processImmediate (node:internal/timers:483:21)
      at process.topLevelDomainCallback (node:domain:161:15)
      at process.callbackTrampoline (node:internal/async_hooks:128:24)

  3) Config
       node.js config
         checkNodeOk
           supported nodes
             should succeed if node is 18+:
     AssertionError: expected [Function checkNodeOk] to not throw an error but 'Error: Node version must be at least …' was thrown
      at Context.<anonymous> (test/unit/config.spec.js:165:39)
      at processImmediate (node:internal/timers:483:21)
      at process.topLevelDomainCallback (node:domain:161:15)
      at process.callbackTrampoline (node:internal/async_hooks:128:24)

@mykola-mokhnach
Copy link
Collaborator

mykola-mokhnach commented Dec 11, 2024 •
edited
Loading

we should ignore them?

  1) Config
       node.js config
         checkNodeOk
           supported nodes
             should succeed if node is 14.17+:
     AssertionError: expected [Function checkNodeOk] to not throw an error but 'Error: Node version must be at least …' was thrown
      at Context.<anonymous> (test/unit/config.spec.js:155:39)
      at processImmediate (node:internal/timers:483:21)
      at process.topLevelDomainCallback (node:domain:161:15)
      at process.callbackTrampoline (node:internal/async_hooks:128:24)

  2) Config
       node.js config
         checkNodeOk
           supported nodes
             should succeed if node is 16.13+:
     AssertionError: expected [Function checkNodeOk] to not throw an error but 'Error: Node version must be at least …' was thrown
      at Context.<anonymous> (test/unit/config.spec.js:160:39)
      at processImmediate (node:internal/timers:483:21)
      at process.topLevelDomainCallback (node:domain:161:15)
      at process.callbackTrampoline (node:internal/async_hooks:128:24)

  3) Config
       node.js config
         checkNodeOk
           supported nodes
             should succeed if node is 18+:
     AssertionError: expected [Function checkNodeOk] to not throw an error but 'Error: Node version must be at least …' was thrown
      at Context.<anonymous> (test/unit/config.spec.js:165:39)
      at processImmediate (node:internal/timers:483:21)
      at process.topLevelDomainCallback (node:domain:161:15)
      at process.callbackTrampoline (node:internal/async_hooks:128:24)

rather update to check the compat with node20+
I assume Node18 will be EOL when we release Appium3: https://endoflife.date/nodejs

@KazuCocoa
Copy link
Member

yea, sounds good.

appium/packages/appium/test/unit/config.spec.js

Lines 151 to 167 in 66e3580

describe('supported nodes', function () {
it('should succeed if node is 14.17+', function () {
// @ts-expect-error
process.version = 'v14.17.0';
checkNodeOk.should.not.throw();
});
it('should succeed if node is 16.13+', function () {
// @ts-expect-error
process.version = 'v16.13.0';
checkNodeOk.should.not.throw();
});
it('should succeed if node is 18+', function () {
// @ts-expect-error
process.version = 'v18.0.0';
checkNodeOk.should.not.throw();
});
});
can update for newer ones

@eglitise eglitise added the v3 Appium v3 label Dec 11, 2024
@jlipps
Copy link
Member Author

jlipps commented Dec 12, 2024

hmm I did update these tests but now I can't find the commit!

@jlipps
Copy link
Member Author

jlipps commented Dec 12, 2024

there we go.

KazuCocoa
KazuCocoa approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg, remaining failure is npm install @appium/fake-driver related, which is not possible right now since this pr is the first one to allow 3.0.0-beta.0 for the fake driver

@jlipps jlipps merged commit 71641f1 into appium3 Dec 16, 2024
4 of 6 checks passed
@jlipps jlipps deleted the jlipps/appium3 branch December 16, 2024 20:37
@KazuCocoa KazuCocoa mentioned this pull request Mar 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eglitise eglitise eglitise left review comments

@KazuCocoa KazuCocoa KazuCocoa approved these changes

Assignees
No one assigned
Labels
v3 Appium v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jlipps @KazuCocoa @mykola-mokhnach @eglitise