Skip to content

Improve tabs #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 24, 2021
Merged

Improve tabs #551

merged 3 commits into from
Feb 24, 2021

Conversation

Denyer
Copy link
Contributor

@Denyer Denyer commented Feb 23, 2021 •
edited
Loading

  • When rendering tabs, we loop through the children, we should ignore null children.
  • Preserve the child callback props for the tabs
  • Allow defining an initially selected tab other than the first

@Denyer
Allow conditionally rendering of tabs
3daa0dc 
When rendering tabs, we loop through the children, we should
ignore null children.
@vercel
Copy link

vercel bot commented Feb 23, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/appearherebloom/bloom/H6wsykM18Xn6sGJHebPVHQVBSXDy
✅ Preview: https://bloom-git-task-lfr-3485-appearherebloom.vercel.app

@Denyer Denyer self-assigned this Feb 23, 2021
@Denyer Denyer changed the title Allow conditionally rendering of tabs Improve tabs Feb 23, 2021
@Denyer Denyer marked this pull request as ready for review February 23, 2021 22:22
@Denyer Denyer requested a review from a team as a code owner February 23, 2021 22:22
@Denyer Denyer requested review from jamero102 and tblakey89 and removed request for a team February 24, 2021 08:45
@Denyer Denyer merged commit 008eea0 into master Feb 24, 2021
@delete-merged-branch delete-merged-branch bot deleted the task/LFR-3485 branch February 24, 2021 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamero102 jamero102 Awaiting requested review from jamero102

2 more reviewers

@tblakey89 tblakey89 tblakey89 approved these changes

@zlahham zlahham zlahham approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Denyer Denyer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Denyer @tblakey89 @zlahham