You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 13, 2023. It is now read-only.
Intended outcome: When I wrap a component with a graphql HOC, the behavior of React's calls to componentWillReceiveProps on the underlying component should not change.
Actual outcome: Currently, when wrapping with a HOC, componentWillReceiveProps is no longer called in situations in which it should be.
This is due to the shallowEquals done on all props here:
In step 4, the component state should update via componentWillReceiveProps. It does not.
In this sandbox, we have the exact same App component, without the Apollo HOC: https://codesandbox.io/s/xpyjmknp14 and you can see that the behavior is now correct.
Version: 2.0.4
apollo-client@2.2.1
react-apollo@2.0.4
michalpierzchlewicz, quadsurf, Gregoirevda, olivereisenhut, reggie3 and 2 more