Skip to content

Update ingress-portal.yaml #3933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 8, 2021
Merged

Update ingress-portal.yaml #3933

merged 5 commits into from
Sep 8, 2021

Conversation

lijiansgit
Copy link
Contributor

@lijiansgit lijiansgit commented Aug 30, 2021 •
edited
Loading

What's the purpose of this PR

helm install error:
Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: apiVersion not set
ingress-portal.yaml syntax error:
-}} means whitespace to the right should be consumed，so apiVersion annotated

Which issue(s) this PR fixes:

Fixes #

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

Update ingress-portal.yaml
b67fee8 
-}} means whitespace to the right should be consumed，cause  error: 'apiVersion not set'. (#apiVersion annotated)
@github-actions
Copy link

github-actions bot commented Aug 30, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@nobodyiam
Copy link
Member

Thanks, would you please also help to fix ingress-configservice.yaml and ingress-adminservice.yaml?

@nobodyiam nobodyiam mentioned this pull request Sep 7, 2021
Closed
3 tasks
@nobodyiam
Copy link
Member

@lijiansgit is there any update on this?

@lijiansgit
Copy link
Contributor Author

Thanks, would you please also help to fix ingress-configservice.yaml and ingress-adminservice.yaml?

updated !

@lijiansgit
Copy link
Contributor Author

@lijiansgit is there any update on this?

nothing !

@nobodyiam
Copy link
Member

@lijiansgit please also sign the CLA and update the CHANGES.md, thanks!

@lijiansgit
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@codecov-commenter
Copy link

Codecov Report

Merging #3933 (7628611) into master (560284d) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3933      +/-   ##
============================================
+ Coverage     50.75%   50.78%   +0.02%     
- Complexity     2465     2467       +2     
============================================
  Files           475      475              
  Lines         14608    14608              
  Branches       1523     1523              
============================================
+ Hits           7415     7418       +3     
+ Misses         6665     6664       -1     
+ Partials        528      526       -2
Impacted Files Coverage Δ
.../framework/apollo/spring/property/SpringValue.java 89.47% <0.00%> (+1.75%) ⬆️
...rk/apollo/spring/property/SpringValueRegistry.java 89.18% <0.00%> (+5.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 560284d...7628611. Read the comment docs.

nobodyiam
nobodyiam approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit ec9534f into apolloconfig:master Sep 8, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2021
@nobodyiam nobodyiam added this to the 1.9.1 milestone Sep 8, 2021
@lijiansgit lijiansgit deleted the patch-1 branch September 16, 2021 06:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nobodyiam nobodyiam nobodyiam approved these changes

Assignees
No one assigned
Labels
area/kubernetes
Projects
None yet
Milestone
1.9.1
Development

Successfully merging this pull request may close these issues.
4 participants
@lijiansgit @nobodyiam @codecov-commenter @Anilople