Skip to content

test(apollo-client): make timeout more longer when long poll #3668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2021

Conversation

Anilople
Copy link
Contributor

@Anilople Anilople commented May 8, 2021

What's the purpose of this PR

Fix test failed on some environment.

Which issue(s) this PR fixes:

Fixes #3369

Brief changelog

Add timeout.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2021

Codecov Report

Merging #3668 (82508bd) into master (21ac89c) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3668      +/-   ##
============================================
- Coverage     50.94%   50.93%   -0.01%     
+ Complexity     2329     2328       -1     
============================================
  Files           449      449              
  Lines         14026    14026              
  Branches       1426     1426              
============================================
- Hits           7145     7144       -1     
  Misses         6395     6395              
- Partials        486      487       +1     
Impacted Files Coverage Δ Complexity Δ
.../apollo/internals/RemoteConfigLongPollService.java 77.71% <0.00%> (-0.61%) 28.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21ac89c...82508bd. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 20b8ddb into master May 9, 2021
@nobodyiam nobodyiam deleted the test/fix/more/longer/20210508 branch May 9, 2021 02:11
@nobodyiam nobodyiam added this to the 1.9.0 milestone May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There are test failures on project apollo-client
3 participants