Codecov Report

Merging #3627 (82a3b82) into master (3de1d72) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #3627      +/-   ##
============================================
+ Coverage     50.97%   50.99%   +0.01%     
- Complexity     2329     2330       +1     
============================================
  Files           449      449              
  Lines         14026    14026              
  Branches       1426     1426              
============================================
+ Hits           7150     7152       +2     
+ Misses         6389     6388       -1     
+ Partials        487      486       -1     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3de1d72...82a3b82. Read the comment docs.

It looks good to me, but how we avoid this situation next time.
It seems that there had serval issues about sensitive appId previously, do we need some common utils to fix the same issues?

It seems that there had serval issues about sensitive appId previously, do we need some common utils to fix the same issues?

You are right, there have been several case sensitive issues. Previously we also have this issue for namespace names, and we fixed that via NamespaceUtil#normalizeNamespace.
Maybe we could also write an AppUtil to normalize the app id?

https://github.com/ctripcorp/apollo/blob/943bbb4d56bd9d3bbec291ea17136099a3a60b7c/apollo-configservice/src/main/java/com/ctrip/framework/apollo/configservice/util/NamespaceUtil.java#L28-L40

@nobodyiam I think we can merge this PR first, and create a new issue to build AppUtil.