Skip to content

fix #2768 #2784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 28, 2019
Merged

fix #2768 #2784

merged 4 commits into from
Nov 28, 2019

Conversation

nobodyiam
Copy link
Member

fix #2768 that the namespace length is mis-calculated for private namespaces and public namespaces which don't need to append prefix

@nobodyiam
fix apolloconfig#2768 that the namespace length is mis-calculated for…
a74a005 
… private namespaces and public namespaces which don't need to append prefix
@nobodyiam nobodyiam mentioned this pull request Nov 25, 2019
Closed
@codecov-io
Copy link

codecov-io commented Nov 25, 2019 •
edited
Loading

Codecov Report

Merging #2784 into master will increase coverage by 8.7%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #2784     +/-   ##
===========================================
+ Coverage     50.48%   59.18%   +8.7%     
+ Complexity     2084     1200    -884     
===========================================
  Files           413      196    -217     
  Lines         12666     5951   -6715     
  Branches       1294      636    -658     
===========================================
- Hits           6394     3522   -2872     
+ Misses         5819     2162   -3657     
+ Partials        453      267    -186
Impacted Files Coverage Δ Complexity Δ
.../portal/spi/configuration/LdapGroupProperties.java
...ework/apollo/portal/controller/ItemController.java
...o/configservice/wrapper/DeferredResultWrapper.java
...omponent/emailbuilder/GrayPublishEmailBuilder.java
...k/apollo/portal/controller/FavoriteController.java
...apollo/portal/entity/vo/AppRolesAssignedUsers.java
...nfigservice/ConfigServerEurekaServerConfigure.java
...ponent/emailbuilder/NormalPublishEmailBuilder.java
.../framework/apollo/portal/entity/vo/SystemInfo.java
...rk/apollo/portal/service/NamespaceLockService.java
... and 207 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 232ebeb...aa74675. Read the comment docs.

@coveralls
Copy link

coveralls commented Nov 25, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 54.058% when pulling aa74675 on nobodyiam:fix-2768 into 232ebeb on ctripcorp:master.

@JaredTan95 JaredTan95 added this to the 1.6.0 milestone Nov 26, 2019
@JaredTan95 JaredTan95 added bug Categorizes issue or PR as related to a bug. area/ui Categorizes issue or PR as related to front end labels Nov 26, 2019
@JaredTan95 JaredTan95 merged commit d83c6e2 into apolloconfig:master Nov 28, 2019
@easyfold easyfold mentioned this pull request Jan 8, 2024
Closed
3 tasks
@nobodyiam nobodyiam deleted the fix-2768 branch January 21, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredTan95 JaredTan95 JaredTan95 approved these changes

Assignees
No one assigned
Labels
area/ui Categorizes issue or PR as related to front end bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

新建private的namespace会自动带上部门名计算namespace总长度
4 participants
@nobodyiam @codecov-io @coveralls @JaredTan95