Skip to content

support dataChangeLastModifiedBy display after edited in a namespace #2680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 28, 2019
Merged

support dataChangeLastModifiedBy display after edited in a namespace #2680

merged 12 commits into from
Oct 28, 2019

Conversation

JaredTan95
Copy link
Member

support dataChangeLastModifiedBy display after editing in a namespace, not only in the edit history.

image

@JaredTan95 JaredTan95 requested a review from nobodyiam October 21, 2019 05:22
@JaredTan95 JaredTan95 added this to the 1.6.0 milestone Oct 21, 2019
@coveralls
Copy link

coveralls commented Oct 21, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 54.067% when pulling 09d1347 on last_modified_by into 2b48b3d on master.

@codecov-io
Copy link

codecov-io commented Oct 21, 2019 •
edited
Loading

Codecov Report

Merging #2680 into master will increase coverage by 0.26%.
The diff coverage is 39.13%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2680      +/-   ##
============================================
+ Coverage     50.23%   50.49%   +0.26%     
- Complexity     2061     2082      +21     
============================================
  Files           413      413              
  Lines         12644    12664      +20     
  Branches       1292     1293       +1     
============================================
+ Hits           6352     6395      +43     
+ Misses         5844     5817      -27     
- Partials        448      452       +4
Impacted Files Coverage Δ Complexity Δ
...p/framework/apollo/portal/service/ItemService.java 62.8% <0%> (-0.53%) 16 <0> (ø)
...p/framework/apollo/portal/api/AdminServiceAPI.java 12.57% <0%> (-0.25%) 1 <0> (ø)
...apollo/adminservice/controller/ItemController.java 7.89% <0%> (-0.93%) 2 <0> (ø)
...k/apollo/biz/utils/ConfigChangeContentBuilder.java 89.47% <100%> (+89.47%) 15 <4> (+15) ⬆️
...trip/framework/apollo/portal/entity/bo/ItemBO.java 81.25% <100%> (ø) 8 <1> (ø) ⬇️
...mework/apollo/portal/service/NamespaceService.java 67.1% <66.66%> (-0.47%) 27 <1> (+1)
...va/com/ctrip/framework/apollo/biz/entity/Item.java 88.88% <0%> (+38.88%) 11% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b48b3d...09d1347. Read the comment docs.

nobodyiam
nobodyiam requested changes Oct 22, 2019
View reviewed changes
@JaredTan95 JaredTan95 requested a review from nobodyiam October 23, 2019 06:48
@JaredTan95
Copy link
Member Author

Do I need to fix codecov/patch?

kezhenxu94
kezhenxu94 reviewed Oct 27, 2019
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions

@JaredTan95 JaredTan95 changed the title support dataChangeLastModifiedBy display after editing in a namespace support dataChangeLastModifiedBy display after edited in a namespace Oct 27, 2019
@JaredTan95 JaredTan95 requested a review from kezhenxu94 October 27, 2019 12:44
nobodyiam
nobodyiam approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kezhenxu94
kezhenxu94 approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kezhenxu94 kezhenxu94 merged commit 17261b6 into master Oct 28, 2019
@kezhenxu94 kezhenxu94 deleted the last_modified_by branch October 28, 2019 01:20
@nobodyiam nobodyiam mentioned this pull request Aug 1, 2020
Closed
@nobodyiam nobodyiam mentioned this pull request Mar 26, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobodyiam nobodyiam nobodyiam approved these changes

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@JaredTan95 @coveralls @codecov-io @nobodyiam @kezhenxu94