-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
fix deleted at timestamp #4493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix deleted at timestamp #4493
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4493 +/- ##
=========================================
Coverage 53.45% 53.45%
- Complexity 2701 2702 +1
=========================================
Files 490 490
Lines 15344 15345 +1
Branches 1596 1598 +2
=========================================
+ Hits 8202 8203 +1
- Misses 6584 6585 +1
+ Partials 558 557 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
apollo-common/src/main/java/com/ctrip/framework/apollo/common/entity/BaseEntity.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
apollo-common/src/main/java/com/ctrip/framework/apollo/common/entity/BaseEntity.java
Show resolved
Hide resolved
apollo-common/src/main/java/com/ctrip/framework/apollo/common/entity/BaseEntity.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this PR
Fix the deleted at timestamp field is set for records not deleted.
Which issue(s) this PR fixes:
Fixes #4492
Brief changelog
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.