-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
Add one-click install apollo in Rainbond docs. add a Dockerfile for self-init apollodb #4283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Even though I signed the CLA.PR still seems to be blocked, please help me look at this problem,thanks~ 😂 @nobodyiam |
According to your suggestion, I have submitted an additional commit, please review it again.thanks 😊 @Anilople |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. Please see some comments below.
Co-authored-by: Jason Song <nobodyiam@gmail.com>
Co-authored-by: Jason Song <nobodyiam@gmail.com>
Co-authored-by: Jason Song <nobodyiam@gmail.com>
Co-authored-by: Jason Song <nobodyiam@gmail.com>
Co-authored-by: Jason Song <nobodyiam@gmail.com>
Co-authored-by: Jason Song <nobodyiam@gmail.com>
Co-authored-by: Jason Song <nobodyiam@gmail.com>
the Dockerfile will only stored by Rainbond application template
Codecov Report
@@ Coverage Diff @@
## master #4283 +/- ##
============================================
- Coverage 53.17% 53.16% -0.02%
+ Complexity 2668 2667 -1
============================================
Files 488 488
Lines 15253 15253
Branches 1577 1577
============================================
- Hits 8111 8109 -2
- Misses 6587 6593 +6
+ Partials 555 551 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Anilople Please help to review it again. |
Co-authored-by: wxq <Anilople@outlook.com>
Co-authored-by: wxq <Anilople@outlook.com>
Co-authored-by: wxq <Anilople@outlook.com>
Co-authored-by: wxq <Anilople@outlook.com>
Co-authored-by: wxq <Anilople@outlook.com>
Co-authored-by: wxq <Anilople@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this PR
For this issue #4273
And Dockerfile for self-init apollodb