Skip to content

Conversation

dazuimao1990
Copy link
Contributor

@dazuimao1990 dazuimao1990 commented Mar 29, 2022

What's the purpose of this PR

For this issue #4273

  • Complete documentation for a one-click installation of Apollo based on Rainbond
  • Procedure For one-click installation
  • Modify Apollo configuration based on environment variables or configuration files
  • How to append the environment

And Dockerfile for self-init apollodb

  • How do I build a apollodb that automatically loads SQL initialization during startup

@github-actions
Copy link

github-actions bot commented Mar 29, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@dazuimao1990
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@dazuimao1990
Copy link
Contributor Author

Even though I signed the CLA.PR still seems to be blocked, please help me look at this problem,thanks~ 😂 @nobodyiam

@dazuimao1990
Copy link
Contributor Author

According to your suggestion, I have submitted an additional commit, please review it again.thanks 😊 @Anilople

@dazuimao1990 dazuimao1990 requested a review from Anilople March 30, 2022 08:41
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Please see some comments below.

dazuimao1990 and others added 7 commits March 31, 2022 09:22
Co-authored-by: Jason Song <nobodyiam@gmail.com>
Co-authored-by: Jason Song <nobodyiam@gmail.com>
Co-authored-by: Jason Song <nobodyiam@gmail.com>
Co-authored-by: Jason Song <nobodyiam@gmail.com>
Co-authored-by: Jason Song <nobodyiam@gmail.com>
Co-authored-by: Jason Song <nobodyiam@gmail.com>
Co-authored-by: Jason Song <nobodyiam@gmail.com>
@dazuimao1990 dazuimao1990 requested a review from nobodyiam March 31, 2022 01:46
the Dockerfile will only stored by Rainbond application template
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2022

Codecov Report

Merging #4283 (74201e8) into master (db6a439) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4283      +/-   ##
============================================
- Coverage     53.17%   53.16%   -0.02%     
+ Complexity     2668     2667       -1     
============================================
  Files           488      488              
  Lines         15253    15253              
  Branches       1577     1577              
============================================
- Hits           8111     8109       -2     
- Misses         6587     6593       +6     
+ Partials        555      551       -4     
Impacted Files Coverage Δ
...framework/apollo/openapi/entity/ConsumerAudit.java 42.42% <0.00%> (-6.07%) ⬇️
...mework/apollo/openapi/service/ConsumerService.java 53.38% <0.00%> (-1.70%) ⬇️
...ervice/service/ReleaseMessageServiceWithCache.java 87.05% <0.00%> (+2.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db6a439...74201e8. Read the comment docs.

nobodyiam
nobodyiam previously approved these changes Apr 1, 2022
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam
Copy link
Member

@Anilople Please help to review it again.

Co-authored-by: wxq <Anilople@outlook.com>
Copy link
Contributor

@Anilople Anilople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit cd6d9bd into apolloconfig:master Apr 5, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants