Skip to content

update helm repo related as a follow up for #4125 #4126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2021
Merged

update helm repo related as a follow up for #4125 #4126

merged 1 commit into from
Dec 3, 2021

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

update helm repo related as a follow up for #4125

Which issue(s) this PR fixes:

Fixes #3959

Brief changelog

  1. update helm chart repo url
  2. update helm chart release instructions

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

JaredTan95
JaredTan95 approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@JaredTan95 JaredTan95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaredTan95 JaredTan95 merged commit 0a76c8b into apolloconfig:master Dec 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2021
@nobodyiam nobodyiam deleted the update-helm-repo-url branch December 4, 2021 00:31
@nobodyiam nobodyiam added this to the 2.0.0 milestone Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JaredTan95 JaredTan95 JaredTan95 approved these changes

@lepdou lepdou Awaiting requested review from lepdou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

[Proprosoal] Split helm chart into another repo
2 participants
@nobodyiam @JaredTan95