Failfast for explicit error http request instead of retrying (#296) #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfig#296) - error http status code: 400, 401, 404, 405 - Error Code Description: https://www.apolloconfig.com/#/en/usage/other-language-client-user-guide?id=_16-error-code-description
|
感谢您提出Pull Request，我会尽快Review。我会在1-2日内进行查看或者回复，如果遇到节假日可能会处理较慢，敬请谅解。 |
|
Fantastic work! Could we incorporate some unit tests to ensure coverage of the newly implemented logic? |
|
@nobodyiam Unit tests 已提交（module protocol/http coverage: 61.4% > 69.3%） |
|
Looks like we need to also fix other test cases. |
|
@nobodyiam fixed, and successfully ran all test cases |
zouyx
pushed a commit
that referenced
this pull request
Mar 27, 2024
Failfast for explicit error http request instead of retrying (#296)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#296