Correctly exclude a few keys from being JSON encoded #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most Docker API parameters take JSON values but some array parameters must be passed as multiple querystring parameters. Two known such parameters are `t` and `extrahosts` for the `/build` endpoint. There may be others. This changes Modem to behave in a similar way: encode values to JSON by default, except the known special cases. This properly fixes apocas/dockerode#605 and apocas#139 and effectively reverts apocas#133 and apocas#134.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most Docker API parameters take JSON values but some array parameters must be passed as multiple querystring parameters. Two known such parameters are
tandextrahostsfor the/buildendpoint. There may be others.This changes Modem to behave in a similar way: encode values to JSON by default, except the known special cases.
This properly fixes apocas/dockerode#605 and #139 and effectively reverts #133 and #134.