Skip to content

Replace filtering.Field type with maps #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2022
Merged

Replace filtering.Field type with maps #678

merged 1 commit into from
Jul 27, 2022

Conversation

seaneganx
Copy link
Contributor

@seaneganx seaneganx commented Jul 27, 2022 •
edited by timburks
Loading

As discussed here.

@seaneganx seaneganx requested a review from timburks July 27, 2022 17:23
@seaneganx seaneganx mentioned this pull request Jul 27, 2022
Merged
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #678 (9773a54) into main (dfc3189) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #678   +/-   ##
=======================================
  Coverage   54.09%   54.09%           
=======================================
  Files          78       78           
  Lines        7326     7326           
=======================================
  Hits         3963     3963           
  Misses       2940     2940           
  Partials      423      423
Impacted Files Coverage Δ
...r/registry/internal/storage/filtering/filtering.go 86.04% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

timburks
timburks approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@timburks timburks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks

@seaneganx seaneganx merged commit e7f9deb into apigee:main Jul 27, 2022
@seaneganx seaneganx deleted the refactor/remove-filtering-field branch July 27, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timburks timburks timburks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Apigee API Registry
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seaneganx @timburks