This repository was archived by the owner on Nov 8, 2024. It is now read-only.
fix issue 749 #754
Merged
fix issue 749 #754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pksunkara
approved these changes
Oct 9, 2019
|
Looks like a merge conflict. |
|
@klokane can you rebase this branch to resolve the conflict so we can merge it? |
be42475 to
b5c33f4
Compare
|
rebased |
tjanc
suggested changes
Oct 17, 2019
| ] | ||
| } | ||
| }, | ||
| "content": "duplicit value in enumeration" |
There was a problem hiding this comment.
I think this warning is correct and shouldn't be removed. The only thing that needed changing is that the "mson example value" of an enum is added to enumerations after all it's nested members are. What do you think?
There was a problem hiding this comment.
Although, perhaps it makes better sense to give a warning in the exact opposite example, where we introduce a new type to enumerations because the example does not match any nested type.
tjanc
approved these changes
Oct 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #749
Ignore enum duplicity if defined inline and later again in members