SLING-8519 - Improve CLI parsing and general look and feel #4
Conversation
raducotescu
commented
Jun 17, 2019
- embedded picocli.CommandLine version 4.0.0-beta-1b
- refactored commands
* embedded picocli.CommandLine version 4.0.0-beta-1b * refactored commands
|
@raducotescu - curious, why did you add the picocli source code to the project? I would've thought we can pull it in as a Maven dependency. Incidentally, this makes the build fail as the SonarQube plugin chokes on this file. |
|
@rombert, currently picocli doesn't offer an OSGi friendly bundle. See [0]. I guess I could embed the module for now into the Committer CLI bundle and once picocli provides an OSGi-ready jar we can omit the embed. [0] - remkop/picocli#734 |
|
@raducotescu - sounds good to me ! I see your PR has already been merged and
So you can either wait for the release or embed it, it's fine for me either way. |
|
I'd wait for the release and then merge our PR as well. |
|
Picocli 4.0.0-beta-2 has been released. The picocli user manual now has a (very brief) section that mentions that the main jar is now an OSGi bundle. If anyone has recommendations to improve this section, any feedback is welcome! Enjoy! |
* switched to picocli 4.0.0-beta-2 which provides OSGi support
* minor code cleanup