-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Closed
apache/skywalking-eyes
#120Labels
bugSomething isn't working and you are sure it's a bug!Something isn't working and you are sure it's a bug!
Milestone
Description
Search before asking
- I had searched in the issues and found no similar issues.
Apache SkyWalking Component
License Tools (apache/skywalking-eyes)
What happened
For example, the license of my Go project is Apache-2.0
, I add the mod github.com/ericlagergren/go-coreutils to the project, the license of this mod is GPL-3.0 and GPL-3.0-or-later
, In theory Apache-2.0
and GPL-3.0
are incompatible, but dep check
passed.
What you expected to happen
dep check failed.
How to reproduce
Just run go get github.com/ericlagergren/go-coreutils
in skywalking-eyes
, and run license-eye dep check
.
Anything else
Maybe the code https://github.com/apache/skywalking-eyes/blob/f461a46e74e5fa22e9f9599a355ab4f0ac265469/pkg/deps/check.go#L67 only compare license string with ==
rather than handling the AND
, OR
keywords.
Are you willing to submit PR?
- Yes I am willing to submit a PR!
Code of Conduct
- I agree to follow this project's Code of Conduct
wu-sheng and kezhenxu94
Metadata
Metadata
Assignees
Labels
bugSomething isn't working and you are sure it's a bug!Something isn't working and you are sure it's a bug!