Skip to content

Conversation

leizhiyuan
Copy link
Contributor

@leizhiyuan leizhiyuan commented Jan 26, 2024

What is the purpose of the change

fix #616

Brief changelog

change handleMessage to public, so user can fetch some header info uniformly

Verifying this change

    @Pointcut("execution(* org.apache.rocketmq.spring.support.DefaultRocketMQListenerContainer.handleMessage*(..))")
    private void listenerConsume() {
    }


 @Around("listenerConsume()")
    public Object aroundListenerConsume(ProceedingJoinPoint pjp) throws Throwable {

//do something     
}

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@lizhanhui
Copy link
Contributor

It makes sense and helps improve extensibility.

@lizhanhui lizhanhui merged commit 9ea8f71 into apache:master Jan 26, 2024
@lihongli24
Copy link

升到了2.3.0 好像还是不行

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

will handleMessage be public,so users can do some intecept before consumeMessage
3 participants