Skip to content

Conversation

MartinDai
Copy link
Contributor

What is the purpose of the change

Support RocketMQ 5.0.0

Brief changelog

Support RocketMQ 5.0.0

Verifying this change

done

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • [] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • [] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist.
  • [] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • [] If this contribution is large, please file an Apache Individual Contributor License Agreement.

@RongtongJin RongtongJin merged commit eab2321 into apache:master Dec 8, 2022
@RongtongJin RongtongJin added this to the 2.2.3 milestone Jan 29, 2023
@wuwen5
Copy link

wuwen5 commented Oct 12, 2023

Is this the release of the minor version (2.2.2 to 2.2.3), directly upgrading the rocketmq-client dependency to v5 ? This may be very dangerous for users, as the server may be in v4 version, while the client have upgraded directly to v5 after a revision version.

It is not recommended to upgrade a major version dependency in an upgrade with the third version number, A third digit in the product release number designated maintenance release.

@RongtongJin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants