[ISSUE #481] Add defaultNamespace to both producer and consumer . (#481) #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShannonDing
reviewed
Aug 24, 2022
rocketmq-spring-boot/src/main/java/org/apache/rocketmq/spring/support/RocketMQUtil.java
Show resolved
Hide resolved
ShannonDing
approved these changes
Aug 26, 2022
duhenglucky
previously approved these changes
Sep 6, 2022
ShannonDing
approved these changes
Sep 6, 2022
duhenglucky
reviewed
Sep 6, 2022
| public static String getNamespace(String specifiedNamespace, String defaultNamespace) { | ||
| // prefer to use annotation namespace | ||
| // if is empty a default namespace will be used | ||
| return !StringUtils.hasLength(specifiedNamespace) && StringUtils.hasLength(defaultNamespace) ? defaultNamespace : specifiedNamespace; |
There was a problem hiding this comment.
How about using the isBlank method to avoid the influence brought by whitespace?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Add defaultNamespace to both producer and consumer
Brief changelog
prefer to use the namespace specified by annotation, or a defaultNamespace from property file will be used.